Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identify not compiling for wasm #1326

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Fix identify not compiling for wasm #1326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocols/identify/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ keywords = ["peer-to-peer", "libp2p", "networking"]
categories = ["network-programming", "asynchronous"]

[dependencies]
async-std = "1.0"
bytes = "0.4"
futures_codec = "0.3.1"
futures = "0.3.1"
Expand All @@ -24,6 +23,7 @@ wasm-timer = "0.2"
unsigned-varint = { version = "0.2.3", features = ["futures-codec"] }

[dev-dependencies]
async-std = "1.0"
Copy link
Contributor

@twittner twittner Nov 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably import async-std everywhere as 1 instead of 1.x. According to their stability policy, changes in minor and patch versions are backwards compatible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

async-std = "1" and async-std = "1.0" should do exactly the same thing. Cargo will pull async-std 1.1 even if we say 1.0.

libp2p-mplex = { version = "0.13.0", path = "../../muxers/mplex" }
libp2p-secio = { version = "0.13.0", path = "../../protocols/secio" }
libp2p-tcp = { version = "0.13.0", path = "../../transports/tcp" }
Expand Down