muxers/yamux: Update to yamux v0.10.1-rc.1 #2539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All green on my side with this fix. |
|
Haven't tested with a production setup but my current prototypes work fine with this change! |
|
I left this running in one of our testnet nodes, I'll update in a few days |
🙏 anything unusual happening on the testnet node @divagant-martian? |
|
after a week I have not seen any bad behaviour in our nodes |
|
Thanks @appaquet for the impressive debugging work. Thanks @thomaseizinger and @divagant-martian for testing the release candidate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in the
yamuxv0.10.1-rc.1is tricky (see libp2p/rust-yamux#130). I would like it to be tested on a larger deployment before releasing it to the wild.Anyone has some time to deploy it on their infrastructure? @divagant-martian or @thomaseizinger?
Also @appaquet can you confirm once more that this is fixing all issues on your end?