Fix connection flush #130
Merged
Fix connection flush #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
reviewed
Feb 23, 2022
src/connection.rs
Outdated
| return Poll::Ready(res); | ||
| } | ||
|
|
||
| if let Poll::Ready(Err(err)) = socket.poll_flush_unpin(cx) { |
There was a problem hiding this comment.
I guess we assume that for all implementations of Sink poll_flush_unpin is cheap? If not, we could stop calling poll_flush_unpin once it returns Poll::Ready(Ok(())).
There was a problem hiding this comment.
I think it makes sense. But we need to make sure to reset every time we write to the underlying IO
Co-authored-by: Max Inden <mail@max-inden.de>
|
@mxinden Updated. I don't know if you had something else in mind, but it does the trick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the full conversation here: libp2p/rust-libp2p#2461
The bump to Yamux 0.10 in libp2p broke the wasm-ext transport (used for WebSocket transport in WebAssembly). It turns out that the wasm-ext implementation makes it more prone to yield a
Pendingon apoll_next(see this). When used in conjunction with Noise, a frame may get buffered and only written to the underlying I/O stream when flushing it (see this)In #112, flushing is no longer awaited, but instead, is called at each iteration of the
nextloop inConnection(see this). Unfortunately, when using wasm-ext with Noise, frames may never get written until the next iteration is triggered by another event (incoming frame or stream/control events).As discussed in libp2p's issue, a fix is to make sure that flushing the I/O stream gets progressed in the main loop. I also think that
flush_nowaitis not required anymore since flushing is now actively done in the loop.