Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexicon: Ascend and Descend buttons in Management Bar not visible on Mobile or minimized browsers #1252

Closed
fortunatomaldonado opened this issue Oct 22, 2018 · 6 comments

Comments

@fortunatomaldonado
Copy link
Member

When using Liferay on a mobile device/smaller browser size, you do not have the ability to sort content due to the ascending and descending arrows missing from the UI. This can be reproduced in all instances of management bar.

Steps to reproduce:

  1. Go to Web Content and add a folder and give it a name
  2. Look at the management bar an notice you are able to sort content with asc/desc buttons.
  3. Shrink browser size or visit Liferay instance on mobile
pat270 pushed a commit to pat270/clay that referenced this issue Oct 30, 2018
…line-block` to display links/buttons inside collapsing navigation inline
pat270 added a commit that referenced this issue Oct 30, 2018
Fixes #1252 - Management Bar added .management-bar-item-xs-inline-block
@pat270
Copy link
Member

pat270 commented Oct 30, 2018

This is fixed in Lexicon CSS 1.0.29.

@pat270 pat270 closed this as completed Oct 30, 2018
@duracell80
Copy link

Can anyone offer any breadcrumbs of explanation of why Lexicon issues are being reported in Clay and why Lexicon CSS site isn't being updated? And because this affects _unstyled / _styled in DXP 7.0 we as theme maintainers need WAY more details and help in what version information and NPM activity we need to conduct to keep pace with Liferay themes.

@pat270
Copy link
Member

pat270 commented Dec 3, 2018

@duracell80 Sorry about the site not being updated, we'll get this updated soon. I filed an issue at #1342.

Lexicon CSS is under https://github.com/liferay/clay/tree/1.x which is why issues are being reported in this repo.

For the documentation site not being updated, https://github.com/jbalsas/lexiconcss/pulls.

In the mean time, changes for 1.0.27, 1.0.28, and 1.0.29 can be found at https://github.com/liferay/clay/blob/1.x/CHANGELOG.md.

/cc @jbalsas

@duracell80
Copy link

duracell80 commented Dec 3, 2018

Wow that really is confusing.

This pull request here is an issue I had reported with hidden-xs being applied to the sort arrows ... I'm highly confused as to why the change was made to CSS and not HTML, given that it was the HTML at fault and not Lexicon?

I'm being told by support that this PR resolves an animation issue. Additionally I'm seeing animations in IE11 crash the browser when mousing out of a web content title field into a different field. 100% CPU usage, causing users in IE to not be able to even write web content due to this UI performance issue.

Currently I have no real grounding on how to proceed and can't trace a clear path given the information I was directed to on two separate issues.

@pat270
Copy link
Member

pat270 commented Dec 3, 2018

The changes in this pull were only to allow the sort arrow buttons to be aligned on the same line as Order by: {property} in smaller screens. The hidden-xs class should have been removed in the markup for 7.0. If it's still there it's a regression and needs to be fixed.

#1266 only fixes an animation issue with the Product Menu and other slide out navigations in IE11 and isn't related to the editable title element in web content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants