Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clay CSS should support Ruby Sass #1270

Closed
pat270 opened this issue Oct 29, 2018 · 1 comment
Closed

Clay CSS should support Ruby Sass #1270

pat270 opened this issue Oct 29, 2018 · 1 comment
Labels
comp: clay-css Issues related to Clay CSS status: next-release Issues that will enter into the next release

Comments

@pat270
Copy link
Member

pat270 commented Oct 29, 2018

Hey Team,
This is an issue from the slack chat.

I have tried to upgrade my liferay theme from 7.0 to 7.1.
My theme contains a .sass files and I need ruby sass.
After upgrade I had this error (where this file is not mine):

[10:26:09] Starting 'build:compile-ruby-sass'...
[10:26:10] error build/_css/clay/variables/_bs4-variable-overwrites.scss (Line 11: Invalid CSS after "...nput-margin-x: ": expected expression (e.g. 1px, bold), was "!default;")

So, I have tried to create an empty sample theme (https://github.com/davideabbatiello/samples/blob/master/sample-theme/package.json) without using gulp upgrade and the error is the same.

This particular issue can be fixed by using node-sass and passing in some config options in the theme task.

How important is it to support Ruby Sass? We will need to modify the Bootstrap source code to fix this bug. If we decide to modify how do we organize our changes vs the Bootstrap repo's?
@marcoscv-work
Copy link
Member

I think is better if he migrates her .sass to .scss, using an npm plugin or online application like https://www.sassmeister.com

uses .sass instead of .scss is strange, .sass is very old and not common use

on the other hand, In this way, he only needs to do the conversion once

This was referenced Nov 10, 2018
Merged
Closed
pat270 added a commit to pat270/clay that referenced this issue Nov 19, 2018
@pat270
Fixes: liferay#1270 - (ClayCSS) Deprecated $clay-unset and don't us…
4b9b348 
…e variable resets because it isn't in the Sass spec

Fixes: liferay#1270 - (ClayCSS) Add missing semi colon in Sheet variable

Fixes: liferay#1270 - (ClayCSS) Mixin `clay-custom-grid-columns` base Sass map is being overwritten in RubySass
@pat270 pat270 mentioned this issue Nov 19, 2018
Merged
pat270 added a commit to pat270/clay that referenced this issue Nov 19, 2018
@pat270
Fixes: liferay#1270 - (ClayCSS) Deprecated $clay-unset and don't us…
96211dd 
…e variable resets because it isn't in the Sass spec

Fixes: liferay#1270 - (ClayCSS) Add missing semi colon in Sheet variable

Fixes: liferay#1270 - (ClayCSS) Mixin `clay-custom-grid-columns` base Sass map is being overwritten in Ruby/Dart Sass

Fixes: liferay#1270 - (ClayCSS) Dart Sass no longer supports extending compound selectors e.g. `.primary.focus` added placeholders `%btn-*-focus` and `%btn-outline-*-focus`
jbalsas added a commit that referenced this issue Nov 22, 2018
@jbalsas
Merge pull request #1317 from pat270/clay--1270
ff29726 
Fixes: #1270 - (ClayCSS) Deprecated `$clay-unset` and don't use varia…
@matuzalemsteles matuzalemsteles added status: next-release Issues that will enter into the next release comp: clay-css Issues related to Clay CSS labels Nov 23, 2018
@pat270 pat270 mentioned this issue Feb 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: clay-css Issues related to Clay CSS status: next-release Issues that will enter into the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pat270 @marcoscv-work @matuzalemsteles