Fixes: #1270 - (ClayCSS) Deprecated $clay-unset and don't use varia…
#1317
Conversation
…e variable resets because it isn't in the Sass spec Fixes: liferay#1270 - (ClayCSS) Add missing semi colon in Sheet variable Fixes: liferay#1270 - (ClayCSS) Mixin `clay-custom-grid-columns` base Sass map is being overwritten in Ruby/Dart Sass Fixes: liferay#1270 - (ClayCSS) Dart Sass no longer supports extending compound selectors e.g. `.primary.focus` added placeholders `%btn-*-focus` and `%btn-outline-*-focus`
| // variables in version 2 because it violates the Sass spec. If you | ||
| // are using libsass you can still unset variables with the syntax | ||
| // `$my-var: !default;`. | ||
| $clay-unset: clay-unset !default; |
There was a problem hiding this comment.
Could we use @warn here so this shows to developers using it?
There was a problem hiding this comment.
@jbalsas Adding @warn will spam the deprecation warning on every compile even if they're not using it. Maybe we can provide some documentation on clayui.com?
There was a problem hiding this comment.
I take that we can't detect variable usage, just mixins, right?
| // variables in version 2 because it violates the Sass spec. If you | ||
| // are using libsass you can still unset variables with the syntax | ||
| // `$my-var: !default;`. | ||
| $clay-unset: clay-unset !default; |
There was a problem hiding this comment.
Could we use @warn here so this shows to developers using it?
|
Hey @pat270, I'm merging for now, we'll need to add a warning whenever we upgrade and remove it. For that... maybe we could start using https://github.com/salesforce-ux/sass-deprecate, that way, when we try to upgrade to 3.0.0 we'll automatically have everything we need to remove documented. Could you take a look to see if this would bring us some benefits? Thanks! |
…ble resets because it isn't in the Sass spec
Fixes: #1270 - (ClayCSS) Add missing semi colon in Sheet variable
Fixes: #1270 - (ClayCSS) Mixin
clay-custom-grid-columnsbase Sass map is being overwritten in RubySass