Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to add tests for clay-charts-react #1293

Closed
bryceosterhaus opened this issue Nov 7, 2018 · 0 comments
Closed

Unable to add tests for clay-charts-react #1293

bryceosterhaus opened this issue Nov 7, 2018 · 0 comments
Labels
status: next-release Issues that will enter into the next release

Comments

@bryceosterhaus
Copy link
Member

There are some issues with conflicting versions of babel and jest. So we should fall back to the same version that clay-charts is using.
bryceosterhaus added a commit to bryceosterhaus/clay that referenced this issue Nov 8, 2018
@bryceosterhaus
Fixes liferay#1293 - Add tests for clay-charts-react
56d934f
bryceosterhaus added a commit to bryceosterhaus/clay that referenced this issue Nov 8, 2018
@bryceosterhaus
Fixes liferay#1293 - Add tests for clay-charts-react
459f3aa
bryceosterhaus added a commit to bryceosterhaus/clay that referenced this issue Nov 8, 2018
@bryceosterhaus
Fixes liferay#1293 - Add tests for clay-charts-react
67698cd
bryceosterhaus added a commit to bryceosterhaus/clay that referenced this issue Nov 8, 2018
@bryceosterhaus
Fixes liferay#1293 - Add tests for clay-charts-react
64e65df
jbalsas added a commit that referenced this issue Nov 14, 2018
@jbalsas
Merge pull request #1294 from bryceosterhaus/develop
37e1473 
Fixes #1293 - Add tests for clay-charts-react
@jbalsas jbalsas added the status: next-release Issues that will enter into the next release label Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: next-release Issues that will enter into the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbalsas @bryceosterhaus