Fixes #1293 - Add tests for clay-charts-react #1294
Merged
+231
−814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryceosterhaus
force-pushed
the
develop
branch
3 times, most recently
from
67698cd to
64e65df
Compare
|
hey @bryceosterhaus, I think we can try to update the babel version to 7.x for all packages and see what happens. We have to analyze this, I had seen some cases where the babel transformed some code to specifications with use of |
|
Just started reviewing :) |
Sent from 
|
hey @bryceosterhaus, It would be something interesting then we think of a way to create tests to ensure the consistency of APIs that are passed to the charts in react and metal. |
|
Hey @bryceosterhaus, I think this is conflicting with our fix for This is looking cool! 👏 |
bryceosterhaus
force-pushed
the
develop
branch
from
64e65df to
70d8451
Compare
|
Updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a bunch of issues getting jest/yarn/lerna to work with different versions of babel so I ended up just falling back to the same babel version for all the packages. This allowed em to write some basic render tests for clay-charts-react