Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing information in filterLabelCloseClicked #1467

Closed
jbalsas opened this issue Jan 23, 2019 · 2 comments
Closed

Missing information in filterLabelCloseClicked #1467

jbalsas opened this issue Jan 23, 2019 · 2 comments
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) status: next-release Issues that will enter into the next release type: enhancement Issues that are open to bring improvements or refinement of code

Comments

@jbalsas
Copy link
Contributor

jbalsas commented Jan 23, 2019

When showing filter label items in the management toolbar, it's not really possible to implement a handleFilterLabelCloseClicked handler since the fired event has no associated data to know which filter was closed.

Additionally, one option that was mentioned by @adolfopa and @4lejandrito was that they could predict the urls beforehand, so we could simply make those links that do a standard navigation (or handle this globally for them)

@jbalsas jbalsas added type: enhancement Issues that are open to bring improvements or refinement of code comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) labels Jan 23, 2019
@4lejandrito
Copy link
Member

4lejandrito commented Jan 23, 2019

Hi guys,

I see 2 options:

  1. We can pass the name of the attribute to be removed from the current URL and you guys take care of it internally. Easier for us, harder for you, less flexible.
  2. We can remove it ourselves in the backend and pass the whole URL to the label. This way you just need to set it to the href of the anchor for example. Harder for us, easier for you, more flexible.

I personally prefer option 2 even if it is more code on our side because it gives us more freedom to manipulate the URL in the precise way we need. And it is what @jbalsas mentioned.

@carloslancha
Copy link
Contributor

For now fixing this we're passing correct data through components so it can be handled. From portal we'll add support for removeLabelURL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) status: next-release Issues that will enter into the next release type: enhancement Issues that are open to bring improvements or refinement of code
Projects
None yet
Development

No branches or pull requests

3 participants