Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1507 (relates to LPS-89868). Prevent 'undefined' from appearing in Clay management toolbar by setting the search value to empty string if its value is falsy #1

Closed
wants to merge 370 commits into from

Conversation

jrao
Copy link

@jrao jrao commented Feb 4, 2019

No description provided.

jbalsas and others added 30 commits November 27, 2018 14:16
ClayCSS: Add an SVG icon for the Kazakhstan flag
 Fixes liferay#1242 - Adds an alert informing the discontinuation of the title and focusable API
…t are interactive

Fixes liferay#1283 - Mixin `clay-label-size` should be able to resize `.label-item .lexicon-icon` and added options to configure `$label-link-color`, `$item-spacer-x`, `$item-spacer-y`, `$sticker-size`, and `$sticker-border-radius`

Fixes liferay#1283 - Labels added options to configure `$label-sticker-border-radius`, `$label-sticker-size`, `$label-item-spacer-y`

Fixes liferay#1283 - Labels added Sass maps `$label-primary`, `$label-secondary`, `$label-success`, `$label-info`, `$label-warning`, `$label-danger`, `$label-light`, `$label-dark` and use mixin `clay-label-variant` to style labels

Fixes liferay#1283 - Labels deprecated `$label-primary-*`, `$label-secondary-*`, `$label-success-*`, `$label-info-*`, `$label-warning-*`, `$label-danger-*`, `$label-light-*`, `$label-dark-*` variables

Fixes liferay#1283 - Labels added Sass maps `$label-primary-close`, `$label-secondary-close`, `$label-success-close`, `$label-info-close`, `$label-warning-close`, `$label-danger-close`, `$label-light-close`, `$label-dark-close`
Fixes liferay#1283 - Forms `.form-control.focus` should show input in focus state
…d have hover state color

Fixes liferay#1283 - Labels `button.label` should have cursor pointer and have same styles as `a.label`
Test Site: Update SVG icon markup to use `focusable="false" role="presentation"`
(clayui.com) Update SVG icon markup to use `focusable="false" role="presentation"`
ClayCSS: Create markup for labels in input
…bel` icon size should be 12px and sticker size should be 14px
Fixes liferay#1345 - ClayCSS add semi-colon and `!default` flag to variables…
Fixes liferay#1343 - ClayCSS Atlas `.label-lg` and `.form-control .label` ic…
Carlos Lancha and others added 26 commits January 22, 2019 18:31
Fixes liferay#1422 - (Clayui.com) Move Multi Select examples to Selectors page
Fixes liferay#1441 - (Clayui.com) Updates Clay packages at clayui.com
…bels

Fixes liferay#1467 - Send useful filter label item data through components to Management Toolbar
Fixes liferay#1463 - Add support for icons in clay cards stickers
…ar by setting the search value to empty string if its value is falsy
@SpencerWoo
Copy link
Owner

SpencerWoo commented Feb 5, 2019

@jrao
(1) formatting
look at your commit and spaces

(2) commit formmating
Follow the other issue's commit convention for message -- example liferay#1467

(3) write a description
In the least link the issue we're coming from -- in this case liferay#1507

The fix itself is straightforward so you can PR the clay repo directly (probably 2.x branch, but check yourself) after you fix these mistakes

@SpencerWoo SpencerWoo closed this Feb 5, 2019
@jrao
Copy link
Author

jrao commented Feb 5, 2019

Sent liferay#1508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.