Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown menu with lists markup is not looking correctly #425

Closed
marcoscv-work opened this issue Jan 17, 2018 · 3 comments
Closed

Dropdown menu with lists markup is not looking correctly #425

marcoscv-work opened this issue Jan 17, 2018 · 3 comments
Labels
status: next-release Issues that will enter into the next release

Comments

@marcoscv-work
Copy link
Member

Dropdown menu markup should be compatible with lists markup to improve semantics. We are currently using

    lists in dropdown-menu, we tried to use "list-unstyled" to reset the ul native styles but it does not look like the best option.

    Examples in components:
    clay-dropdown/demos/
    clay-card/demos/

    image

    image
@pat270
Copy link
Member

pat270 commented Jan 17, 2018

Pattern for dropdown-menu with ul, li:

<ul class="dropdown-menu">
    <li><a class="dropdown-item" href="#">Edit</a></li>
    <li class="dropdown-divider></li>
    <li><a class="dropdown-item" href="#">Save</a></li>
</ul>

@carloslancha
Copy link
Contributor

Hey @pat270

Could you please give us the complete markup in both cases (ul - li and divs), with search form, alert, etc...? Just to be sure we're not messing it up ;)

Thx!!

pat270 added a commit to pat270/clay that referenced this issue Jan 20, 2018
@pat270
Site: (liferay#425) Update all dropdown markup to use ul li
fd6ea36
pat270 added a commit to pat270/clay that referenced this issue Jan 22, 2018
@pat270
Site: (liferay#425) Navbar forgot to change div to ul
8349c4c
robframpton pushed a commit to robframpton/clay that referenced this issue Jan 23, 2018
@pat270
Site: (liferay#425) Navbar forgot to change div to ul
870db2c
pat270 added a commit to pat270/clay that referenced this issue Jan 24, 2018
@pat270
Site: (liferay#425) Update all dropdown markup to use ul li
4205130
@carloslancha carloslancha mentioned this issue Jan 25, 2018
Closed
jbalsas added a commit that referenced this issue Jan 25, 2018
@jbalsas
Merge pull request #461 from carloslancha/ClayDropdownListMarkup
8c5e7fe 
Use new markup for ClayDropdown  | Fixes #425 and #450
@carloslancha
Copy link
Contributor

Label this as next release

@pat270 pat270 added the status: next-release Issues that will enter into the next release label Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: next-release Issues that will enter into the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pat270 @carloslancha @marcoscv-work