Use new markup for ClayDropdown | Fixes #425 and #450 #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 24, 2018 16:22
carloslancha
changed the title
|
Just started reviewing :) |
Sent from 
| </div> | ||
| {/if} | ||
| {/if} | ||
| <div class="dropdown-subheader" role="presentation"> |
There was a problem hiding this comment.
hey @carloslancha, In cases of using groups the $label is required in soy but no error is charged, this ends up printing and leaving empty spaces.
There was a problem hiding this comment.
Hey @matuzalemsteles we can't throw any errors 'cause is a deltemplate. I'm adding a conditional anyway. Thx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.