Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sheet-title can contain an "add button" right aligned #547

Closed
marcoscv-work opened this issue Feb 12, 2018 · 1 comment
Closed

sheet-title can contain an "add button" right aligned #547

marcoscv-work opened this issue Feb 12, 2018 · 1 comment
Labels
status: next-release Issues that will enter into the next release

Comments

@marcoscv-work
Copy link
Member

Here an example with what lexicon needs by BS helpers (so we need to it in clay in a correct way):
To consider, the button should be top aligned when title has more than one lin:

https://codepen.io/marcoscv/full/zRwbpQ

image

Approved by Lexicon ( @victorvalle )
@victorvalle
Copy link

Related issue

pat270 added a commit to pat270/clay that referenced this issue Feb 13, 2018
@pat270
Site: (liferay#547) Sheet add .sheet-subtitle examples with `.autof…
00325e3 
…it-row`
marcoscv-work added a commit that referenced this issue Feb 13, 2018
@marcoscv-work
Merge pull request #549 from pat270/clay-547
6b37ed5 
(#547) sheet-subtitle can contain an "add button" right aligned
@pat270 pat270 added the status: next-release Issues that will enter into the next release label Feb 13, 2018
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@pat270
Update: (Fixes liferay#547) Sheet Subtitle added .autofit-row suppo…
e65d417 
…rt so we can align buttons and other content to the left and right and added options to configure `$sheet-subtitle-heading-text-margin-bottom`, `$sheet-subtitle-heading-text-margin-top`

Update: (liferay#547) Utilities `%autofit-row` shouldn't reset `margin-bottom`, it should be reset by the component that needs it

Update: (liferay#547) Utilities added `.heading-start`, `.heading-text`, and `heading-end` for spacing and aligning text inside headings with the `.autofit-row` component, also added options to configure `$heading-spacer-x`, `$heading-text-margin-bottom`, `$heading-text-margin-top`
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@pat270
Site: (liferay#547) Sheet add .sheet-subtitle examples with `.autof…
8771b96 
…it-row`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: next-release Issues that will enter into the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pat270 @marcoscv-work @victorvalle