Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#547) sheet-subtitle can contain an "add button" right aligned #549

Merged
merged 2 commits into from
Feb 13, 2018

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Feb 13, 2018

The updated markup is span heavy, but I think it provides a lot of flexibility for adding buttons to headings or any text component. This pattern should be useful for creating stuff in the Sites section of Lexicon.

…rt so we can align buttons and other content to the left and right and added options to configure `$sheet-subtitle-heading-text-margin-bottom`, `$sheet-subtitle-heading-text-margin-top`

Update: (liferay#547) Utilities `%autofit-row` shouldn't reset `margin-bottom`, it should be reset by the component that needs it

Update: (liferay#547) Utilities added `.heading-start`, `.heading-text`, and `heading-end` for spacing and aligning text inside headings with the `.autofit-row` component, also added options to configure `$heading-spacer-x`, `$heading-text-margin-bottom`, `$heading-text-margin-top`
@marcoscv-work marcoscv-work merged commit 6b37ed5 into liferay:develop Feb 13, 2018
@pat270 pat270 deleted the clay-547 branch July 11, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants