Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btn-sm is not working with btn-unstyled #600

Closed
matuzalemsteles opened this issue Feb 21, 2018 · 7 comments
Closed

btn-sm is not working with btn-unstyled #600

matuzalemsteles opened this issue Feb 21, 2018 · 7 comments
Labels
type: bug Issues reporting that Component is not doing what should be done

Comments

@matuzalemsteles
Copy link
Member

Hey @pat270, in the case of using btn-sm withbtn-unstyled does not seem to work very well, see #599 for an example.

@matuzalemsteles matuzalemsteles added the type: bug Issues reporting that Component is not doing what should be done label Feb 21, 2018
@pat270
Copy link
Member

pat270 commented Feb 22, 2018

@matuzalemsteles I created btn-unstyled because we wanted to use button for interactive elements that didn't have any href attribute. It seemed easier to create a new class instead of using btn-link because there are a lot of css overwrites I needed to add to make it function like an inline element (e.g. a tag) and I would need to re-add btn-link styles to places where we would want it to function like Bootstrap 4 intended.

I prefer not to make btn-unstyled more complicated and would rather add some documentation on it. Is there a specific use case you can show me?

@matuzalemsteles
Copy link
Member Author

I understand, thanks for clarifying and I agree with you. A case use is in ClayDropdown, It may happen to have a button with btn-unstyled along with btn-sm but I do not know if we would have cases with that for now.

@pat270
Copy link
Member

pat270 commented Feb 22, 2018

I see, if that combo can be output I can just add support for it.

@matuzalemsteles
Copy link
Member Author

Sounds good to me.

@carloslancha
Copy link
Contributor

Hey @pat270 there's a case in blogs where they're using a dropdown with a small unstyled button, they can more or less do the trick by passing elementClasses but it would be better if we can add support for it. Thx!

@pat270
Copy link
Member

pat270 commented Feb 22, 2018

@carloslancha When I created .dropdown-action, I ran under the assumption it would be the same color across the board https://lexicondesign.io/docs/patterns/buttons.html, then there became the sites stuff https://lexicondesign.io/docs/patterns/Sites/assetTitleBar.html.

It's possible to create that blue vertical ellipsis button using:

<div class="dropdown">
    <button class="btn btn-outline-primary btn-outline-borderless btn-monospaced btn-sm dropdown-toggle"></button>
    <div class="dropdown-menu"></div>
</div>

with the caveat that the icon size isn't 1rem.

I will probably need to revisit .dropdown-action colors and support for different .btn-* modifiers (e.g. .btn-outline-primary.btn-outline-borderless) so that you can create the action dropdowns in Lexicon Sites. Generally .btn-unstyled shouldn't be used unless you are trying to style a button the same style as a link in a component.

@carloslancha
Copy link
Contributor

@pat270 makes sense, yep :)

pat270 added a commit to pat270/clay that referenced this issue Feb 24, 2018
… Quick Action Item, they now require modifier classes to style them (e.g., `.component-action`)

Update: (liferay#600) `.btn-outline-primary`, `.btn-outline-secondary`, `.component-action` and `.link-outline-secondary` to closest match of Lexicon 2 Sites buttons

Update: Atlas `$btn-padding-x-sm` value to 0.5rem (8px)

Update: (liferay#600) `.btn-outline-borderless` shouldn't show borders when used with `.dropdown-toggle` and update `.link-outline-primary` colors to best match Lexicon 2 Colors

Update: (liferay#600) Management Bar, Pagination, Tables links shouldn't rely on `$dropdown-action-*` colors

Breaking: (liferay#600) Dropdown Action should be able to recieve colors, removed options to configure colors `$dropdown-action-toggle-bg`, `$dropdown-action-toggle-color`, `$dropdown-action-toggle-hover-bg`, `$dropdown-action-toggle-hover-color`, `$dropdown-action-toggle-disabled-bg`, `$dropdown-action-toggle-disabled-color`, `$dropdown-action-toggle-active-bg`, `$dropdown-action-toggle-active-color`

Breaking: (liferay#600) Quick Action should be able to recieve colors, removed options to configure colors `$quick-action-item-bg`, `$quick-action-item-color`, `$quick-action-item-hover-bg`, `$quick-action-item-hover-color`, `$quick-action-item-disabled-bg`, `$quick-action-item-disabled-color`, `$quick-action-item-active-bg`, `$quick-action-item-active-color`

Update: (liferay#600) `.link-outline-primary` remove focus colors

Update: (liferay#600) Mixin `clay-link` added options to configure `btn-focus-box-shadow`, `btn-focus-outline` for focus styles only for `button` if you like

Update: (liferay#600) `button.link-outline-primary` and `button.link-outline-secondary` focus states and `.link-outline-primary`, `.link-outline-secondary` disabled states

Update: (liferay#600) `button.link-outline` should use `$btn-cursor`

Update: (liferay#600) Mixin `clay-link` added option to configure `transition` and `.component-action` to use new properties added to `clay-link`

Breaking: (liferay#600) Quick Action Item removed padding, it now requires `.component-action`
pat270 added a commit to pat270/clay that referenced this issue Feb 24, 2018
… examples related to Lexicon 2 Sites

Site: (liferay#600) Dropdown Action now requires `.component-action` on `.dropdown-toggle`

Site: (liferay#600) Quick Action Item now requires `.component-action`
pat270 added a commit to pat270/clay that referenced this issue Feb 24, 2018
pat270 added a commit to pat270/clay that referenced this issue Feb 24, 2018
… Quick Action Item, they now require modifier classes to style them (e.g., `.component-action`)

Update: (liferay#600) `.btn-outline-primary`, `.btn-outline-secondary`, `.component-action` and `.link-outline-secondary` to closest match of Lexicon 2 Sites buttons

Update: Atlas `$btn-padding-x-sm` value to 0.5rem (8px)

Update: (liferay#600) `.btn-outline-borderless` shouldn't show borders when used with `.dropdown-toggle` and update `.link-outline-primary` colors to best match Lexicon 2 Colors

Update: (liferay#600) Management Bar, Pagination, Tables links shouldn't rely on `$dropdown-action-*` colors

Breaking: (liferay#600) Dropdown Action should be able to recieve colors, removed options to configure colors `$dropdown-action-toggle-bg`, `$dropdown-action-toggle-color`, `$dropdown-action-toggle-hover-bg`, `$dropdown-action-toggle-hover-color`, `$dropdown-action-toggle-disabled-bg`, `$dropdown-action-toggle-disabled-color`, `$dropdown-action-toggle-active-bg`, `$dropdown-action-toggle-active-color`

Breaking: (liferay#600) Quick Action should be able to recieve colors, removed options to configure colors `$quick-action-item-bg`, `$quick-action-item-color`, `$quick-action-item-hover-bg`, `$quick-action-item-hover-color`, `$quick-action-item-disabled-bg`, `$quick-action-item-disabled-color`, `$quick-action-item-active-bg`, `$quick-action-item-active-color`

Update: (liferay#600) `.link-outline-primary` remove focus colors

Update: (liferay#600) Mixin `clay-link` added options to configure `btn-focus-box-shadow`, `btn-focus-outline` for focus styles only for `button` if you like

Update: (liferay#600) `button.link-outline-primary` and `button.link-outline-secondary` focus states and `.link-outline-primary`, `.link-outline-secondary` disabled states

Update: (liferay#600) `button.link-outline` should use `$btn-cursor`

Update: (liferay#600) Mixin `clay-link` added option to configure `transition` and `.component-action` to use new properties added to `clay-link`

Breaking: (liferay#600) Quick Action Item removed padding, it now requires `.component-action`
pat270 added a commit to pat270/clay that referenced this issue Feb 24, 2018
pat270 added a commit to pat270/clay that referenced this issue Feb 24, 2018
… examples related to Lexicon 2 Sites

Site: (liferay#600) Dropdown Action now requires `.component-action` on `.dropdown-toggle`

Site: (liferay#600) Quick Action Item now requires `.component-action`
matuzalemsteles pushed a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
… Quick Action Item, they now require modifier classes to style them (e.g., `.component-action`)

Update: (liferay#600) `.btn-outline-primary`, `.btn-outline-secondary`, `.component-action` and `.link-outline-secondary` to closest match of Lexicon 2 Sites buttons

Update: Atlas `$btn-padding-x-sm` value to 0.5rem (8px)

Update: (liferay#600) `.btn-outline-borderless` shouldn't show borders when used with `.dropdown-toggle` and update `.link-outline-primary` colors to best match Lexicon 2 Colors

Update: (liferay#600) Management Bar, Pagination, Tables links shouldn't rely on `$dropdown-action-*` colors

Breaking: (liferay#600) Dropdown Action should be able to recieve colors, removed options to configure colors `$dropdown-action-toggle-bg`, `$dropdown-action-toggle-color`, `$dropdown-action-toggle-hover-bg`, `$dropdown-action-toggle-hover-color`, `$dropdown-action-toggle-disabled-bg`, `$dropdown-action-toggle-disabled-color`, `$dropdown-action-toggle-active-bg`, `$dropdown-action-toggle-active-color`

Breaking: (liferay#600) Quick Action should be able to recieve colors, removed options to configure colors `$quick-action-item-bg`, `$quick-action-item-color`, `$quick-action-item-hover-bg`, `$quick-action-item-hover-color`, `$quick-action-item-disabled-bg`, `$quick-action-item-disabled-color`, `$quick-action-item-active-bg`, `$quick-action-item-active-color`

Update: (liferay#600) `.link-outline-primary` remove focus colors

Update: (liferay#600) Mixin `clay-link` added options to configure `btn-focus-box-shadow`, `btn-focus-outline` for focus styles only for `button` if you like

Update: (liferay#600) `button.link-outline-primary` and `button.link-outline-secondary` focus states and `.link-outline-primary`, `.link-outline-secondary` disabled states

Update: (liferay#600) `button.link-outline` should use `$btn-cursor`

Update: (liferay#600) Mixin `clay-link` added option to configure `transition` and `.component-action` to use new properties added to `clay-link`

Breaking: (liferay#600) Quick Action Item removed padding, it now requires `.component-action`
matuzalemsteles pushed a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles pushed a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
… examples related to Lexicon 2 Sites

Site: (liferay#600) Dropdown Action now requires `.component-action` on `.dropdown-toggle`

Site: (liferay#600) Quick Action Item now requires `.component-action`
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles pushed a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
… Quick Action Item, they now require modifier classes to style them (e.g., `.component-action`)

Update: (liferay#600) `.btn-outline-primary`, `.btn-outline-secondary`, `.component-action` and `.link-outline-secondary` to closest match of Lexicon 2 Sites buttons

Update: Atlas `$btn-padding-x-sm` value to 0.5rem (8px)

Update: (liferay#600) `.btn-outline-borderless` shouldn't show borders when used with `.dropdown-toggle` and update `.link-outline-primary` colors to best match Lexicon 2 Colors

Update: (liferay#600) Management Bar, Pagination, Tables links shouldn't rely on `$dropdown-action-*` colors

Breaking: (liferay#600) Dropdown Action should be able to recieve colors, removed options to configure colors `$dropdown-action-toggle-bg`, `$dropdown-action-toggle-color`, `$dropdown-action-toggle-hover-bg`, `$dropdown-action-toggle-hover-color`, `$dropdown-action-toggle-disabled-bg`, `$dropdown-action-toggle-disabled-color`, `$dropdown-action-toggle-active-bg`, `$dropdown-action-toggle-active-color`

Breaking: (liferay#600) Quick Action should be able to recieve colors, removed options to configure colors `$quick-action-item-bg`, `$quick-action-item-color`, `$quick-action-item-hover-bg`, `$quick-action-item-hover-color`, `$quick-action-item-disabled-bg`, `$quick-action-item-disabled-color`, `$quick-action-item-active-bg`, `$quick-action-item-active-color`

Update: (liferay#600) `.link-outline-primary` remove focus colors

Update: (liferay#600) Mixin `clay-link` added options to configure `btn-focus-box-shadow`, `btn-focus-outline` for focus styles only for `button` if you like

Update: (liferay#600) `button.link-outline-primary` and `button.link-outline-secondary` focus states and `.link-outline-primary`, `.link-outline-secondary` disabled states

Update: (liferay#600) `button.link-outline` should use `$btn-cursor`

Update: (liferay#600) Mixin `clay-link` added option to configure `transition` and `.component-action` to use new properties added to `clay-link`

Breaking: (liferay#600) Quick Action Item removed padding, it now requires `.component-action`
matuzalemsteles pushed a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles pushed a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
… examples related to Lexicon 2 Sites

Site: (liferay#600) Dropdown Action now requires `.component-action` on `.dropdown-toggle`

Site: (liferay#600) Quick Action Item now requires `.component-action`
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 1, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 5, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 5, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Mar 7, 2018
jbalsas added a commit that referenced this issue Mar 13, 2018
#600 Breaking Dropdown Action Toggle and Quick Action Item require `.component-action`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Development

No branches or pull requests

3 participants