Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#600 Breaking Dropdown Action Toggle and Quick Action Item require .component-action #725

Merged
merged 20 commits into from
Mar 13, 2018
Merged

Conversation

carloslancha
Copy link
Contributor

No description provided.

pat270 and others added 20 commits March 13, 2018 13:01
…Action Item, they now require modifier classes to style them (e.g., `.component-action`)

Update: (#600) `.btn-outline-primary`, `.btn-outline-secondary`, `.component-action` and `.link-outline-secondary` to closest match of Lexicon 2 Sites buttons

Update: Atlas `$btn-padding-x-sm` value to 0.5rem (8px)

Update: (#600) `.btn-outline-borderless` shouldn't show borders when used with `.dropdown-toggle` and update `.link-outline-primary` colors to best match Lexicon 2 Colors

Update: (#600) Management Bar, Pagination, Tables links shouldn't rely on `$dropdown-action-*` colors

Breaking: (#600) Dropdown Action should be able to recieve colors, removed options to configure colors `$dropdown-action-toggle-bg`, `$dropdown-action-toggle-color`, `$dropdown-action-toggle-hover-bg`, `$dropdown-action-toggle-hover-color`, `$dropdown-action-toggle-disabled-bg`, `$dropdown-action-toggle-disabled-color`, `$dropdown-action-toggle-active-bg`, `$dropdown-action-toggle-active-color`

Breaking: (#600) Quick Action should be able to recieve colors, removed options to configure colors `$quick-action-item-bg`, `$quick-action-item-color`, `$quick-action-item-hover-bg`, `$quick-action-item-hover-color`, `$quick-action-item-disabled-bg`, `$quick-action-item-disabled-color`, `$quick-action-item-active-bg`, `$quick-action-item-active-color`

Update: (#600) `.link-outline-primary` remove focus colors

Update: (#600) Mixin `clay-link` added options to configure `btn-focus-box-shadow`, `btn-focus-outline` for focus styles only for `button` if you like

Update: (#600) `button.link-outline-primary` and `button.link-outline-secondary` focus states and `.link-outline-primary`, `.link-outline-secondary` disabled states

Update: (#600) `button.link-outline` should use `$btn-cursor`

Update: (#600) Mixin `clay-link` added option to configure `transition` and `.component-action` to use new properties added to `clay-link`

Breaking: (#600) Quick Action Item removed padding, it now requires `.component-action`
…es related to Lexicon 2 Sites

Site: (#600) Dropdown Action now requires `.component-action` on `.dropdown-toggle`

Site: (#600) Quick Action Item now requires `.component-action`
@carloslancha carloslancha changed the title regen Fixtures expected | Fixes #600 #600 Breaking Dropdown Action Toggle and Quick Action Item require .component-action Mar 13, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 488

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 81.978%

Totals Coverage Status
Change from base Build 486: -0.003%
Covered Lines: 4588
Relevant Lines: 4852

💛 - Coveralls

@jbalsas jbalsas merged commit 22c10a8 into liferay:develop Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants