-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#600 Breaking Dropdown Action Toggle and Quick Action Item require .component-action
#725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Action Item, they now require modifier classes to style them (e.g., `.component-action`) Update: (#600) `.btn-outline-primary`, `.btn-outline-secondary`, `.component-action` and `.link-outline-secondary` to closest match of Lexicon 2 Sites buttons Update: Atlas `$btn-padding-x-sm` value to 0.5rem (8px) Update: (#600) `.btn-outline-borderless` shouldn't show borders when used with `.dropdown-toggle` and update `.link-outline-primary` colors to best match Lexicon 2 Colors Update: (#600) Management Bar, Pagination, Tables links shouldn't rely on `$dropdown-action-*` colors Breaking: (#600) Dropdown Action should be able to recieve colors, removed options to configure colors `$dropdown-action-toggle-bg`, `$dropdown-action-toggle-color`, `$dropdown-action-toggle-hover-bg`, `$dropdown-action-toggle-hover-color`, `$dropdown-action-toggle-disabled-bg`, `$dropdown-action-toggle-disabled-color`, `$dropdown-action-toggle-active-bg`, `$dropdown-action-toggle-active-color` Breaking: (#600) Quick Action should be able to recieve colors, removed options to configure colors `$quick-action-item-bg`, `$quick-action-item-color`, `$quick-action-item-hover-bg`, `$quick-action-item-hover-color`, `$quick-action-item-disabled-bg`, `$quick-action-item-disabled-color`, `$quick-action-item-active-bg`, `$quick-action-item-active-color` Update: (#600) `.link-outline-primary` remove focus colors Update: (#600) Mixin `clay-link` added options to configure `btn-focus-box-shadow`, `btn-focus-outline` for focus styles only for `button` if you like Update: (#600) `button.link-outline-primary` and `button.link-outline-secondary` focus states and `.link-outline-primary`, `.link-outline-secondary` disabled states Update: (#600) `button.link-outline` should use `$btn-cursor` Update: (#600) Mixin `clay-link` added option to configure `transition` and `.component-action` to use new properties added to `clay-link` Breaking: (#600) Quick Action Item removed padding, it now requires `.component-action`
carloslancha
changed the title
regen Fixtures expected | Fixes #600
#600 Breaking Dropdown Action Toggle and Quick Action Item require Mar 13, 2018
.component-action
Pull Request Test Coverage Report for Build 488
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.