Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast Alert needs to be placed at the bottom left and default auto closing time set to 8 secs #910

Closed
victorvalle opened this issue May 21, 2018 · 5 comments
Closed

Toast Alert needs to be placed at the bottom left and default auto closing time set to 8 secs #910

victorvalle opened this issue May 21, 2018 · 5 comments
Assignees
@pat270 @matuzalemsteles
Labels
status: next-release Issues that will enter into the next release

Comments

@victorvalle
Copy link

Please set alert toast to be appear at the bottom left corner of the screen and 8 secs closing time for automatic close ones
@carloslancha
Copy link
Contributor

As far as I know the position of the toast alert is not defined by the component but by where is used.

About the closing time, where is that documented?

Thx!

@jbalsas
Copy link
Contributor

jbalsas commented May 21, 2018 •
edited
Loading

The position for toast alerts is set in clay-css -> https://github.com/liferay/clay/blob/master/packages/clay-css/src/scss/components/_alerts.scss#L142-L157 as we are using the *alert-fixed class in the alerts container.

About closing time, not sure where it was, but we're currently employing 5s (maybe following the old pattern?) -> https://github.com/liferay/clay/blob/master/packages/clay-alert/src/ClayAlertBase.js#L37

@carloslancha
Copy link
Contributor

Oh, ok, is about that class then, not about the component.

About closing time I asume we're following the "old" patter, what I mean is... where's the new one documented? 😅

@victorvalle
Copy link
Author

lexicon-system/2.0/admin/patterns/alerts/system-messages/documentation/alerts-lexicon-documentation

pat270 added a commit to pat270/clay that referenced this issue May 21, 2018
@pat270
Update: (liferay#910) Alerts move .alert-notifications-fixed to the…
0362475 
… bottom left of the screen
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 21, 2018
@matuzalemsteles
Update tests for new case | Fixes liferay#910
346c01a
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 21, 2018
@matuzalemsteles
SF | Fixes liferay#910
77e9d07
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 22, 2018
@matuzalemsteles
Remove delayTime from API and set autoClose boolean and number | F…
8402e1e 
…ixes liferay#910

`autoClose` to true follows the default values and when number follows the values passed by the API.

Default times:
Stripe: 5s
Toast: 8s
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 22, 2018
@matuzalemsteles
Rename _delayTime in favor of _timeToDisappear and `_startDelayTi…
235609d 
…me` for `_startedTime` | Fixes liferay#910
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 22, 2018
@matuzalemsteles
SF | Fixes liferay#910
d03e338
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 22, 2018
@matuzalemsteles
Fixes tests with new cases | Fixes liferay#910
04e56ef
@carloslancha carloslancha changed the title alert toast to be placed bottom left and 8 secs closing time for automatic close ones Toast Alert needs to be placed at the bottom left and default auto closing time set to 8 secs May 23, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 23, 2018
@matuzalemsteles
Removes the alert type check and default time setting | Fixes liferay…
387ae04 
…#910
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 23, 2018
@matuzalemsteles
Sets the default time in the ClayStripe and ClayToast components and …
2a7cadd 
…only passes the duration to ClayAlertBase | Fixes liferay#910
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 23, 2018
@matuzalemsteles
Sets the autoClose validation in soy from ClayAlertBase to any | Fixes …
8a9fa11 
…liferay#910

Soy does not interpret that in ClayToast and ClayStripe we are treating autoClose to always return an `int`. We leave in soy the `autoClose` any and we guarantee that in our STATE in js do the validation to Number.
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 23, 2018
@matuzalemsteles
Updates the ClayAlertBase isomorphic test | Fixes liferay#910
2df744f
carloslancha added a commit that referenced this issue May 24, 2018
@carloslancha
Merge pull request #916 from matuzalemsteles/issue-910
06bd445 
Adds a new `delayTime` option and changes the ClayToast time to 8/s | Fixes #910
@carloslancha carloslancha added the status: next-release Issues that will enter into the next release label May 24, 2018
@pat270
Copy link
Member

pat270 commented May 24, 2018

@victorvalle where should the alert be positioned on small screens? At the bottom still?

jbalsas added a commit that referenced this issue May 25, 2018
@jbalsas
Merge pull request #915 from pat270/clay-910
682091d 
Update: (#910) Alerts move `.alert-notifications-fixed` to the bottom…
pat270 added a commit to pat270/clay that referenced this issue Jun 8, 2018
@pat270
Update: (liferay#910) Alert Notifications Fixed should be aligned top…
e41e167 
… and span full width in smaller screens

Update: (liferay#910) Alert added `.alert-notifications-static-sm-down` for alerts that push content down in small screens

New: (liferay#910) Alert added options to configure `$alert-notifications-max-width-mobile`, `$alert-notifications-static-sm-down-box-shadow`, `$alert-notifications-static-sm-down-margin-bottom`, `$alert-notifications-static-sm-down-margin-left`, `$alert-notifications-static-sm-down-margin-right`, `$alert-notifications-static-sm-down-margin-top`
pat270 added a commit to pat270/clay that referenced this issue Jun 11, 2018
@pat270
Update: (liferay#910) Alert Notifications Fixed should be full width …
991a36c 
…and aligned to the bottom in smaller screens
jbalsas added a commit that referenced this issue Jun 11, 2018
@jbalsas
Merge pull request #989 from pat270/clay-910
aa20bcd 
Update: (#910) Alert Notifications Fixed should be full width and ali…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pat270 pat270

@matuzalemsteles matuzalemsteles

Labels
status: next-release Issues that will enter into the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pat270 @jbalsas @carloslancha @matuzalemsteles @victorvalle