Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: (#910) Alerts move .alert-notifications-fixed to the bottom… #915

Merged
merged 1 commit into from
May 25, 2018

Conversation

pat270
Copy link
Member

@pat270 pat270 commented May 21, 2018

… left of the screen

@jbalsas
Copy link
Contributor

jbalsas commented May 22, 2018

Hey @pat270, thanks for this quick fix!

I think we need to add something more, because as it is now, if you add more than one alert, the container will grow outside the page, while the expectation is that alerts stack from bottom to top.

I discussed with @marcoscv-work some combination of display: flex, flex-direction: column-reversed and the inversion of padding and margin on alerts in this case to achieve the desired effect.

What do you think?

@jbalsas
Copy link
Contributor

jbalsas commented May 24, 2018

Hey @pat270, not sure you saw this... I can merge this but we'd still need to complete the solution. See below image for a more clear example of the problem. You can see a hint of the second alert below the danger one.

screen shot 2018-05-24 at 18 43 03

Expected layout could be:

screen shot 2018-05-24 at 18 44 12

@jbalsas jbalsas merged commit 682091d into liferay:develop May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants