Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Items with no href should not be links in dropdowns but should looks like one #941

Closed
carloslancha opened this issue May 24, 2018 · 0 comments
Closed

Items with no href should not be links in dropdowns but should looks like one #941

carloslancha opened this issue May 24, 2018 · 0 comments
Assignees
@carloslancha
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Milestone
2.1.5

Comments

@carloslancha
Copy link
Contributor

When no href is present in a dropdown item no link should appear but a button, and that button should have pointer cursor.
@carloslancha carloslancha added the type: bug Issues reporting that Component is not doing what should be done label May 24, 2018
@carloslancha carloslancha self-assigned this May 29, 2018
@carloslancha carloslancha added this to the 2.1.5 milestone May 29, 2018
matuzalemsteles added a commit that referenced this issue May 29, 2018
@matuzalemsteles
Merge pull request #953 from carloslancha/issue-941_Item_As_Button_No…
9bb4139 
…t_Link

Render a button as a dropdown item if no href is passed to an item with default type | Fixes #941
@matuzalemsteles matuzalemsteles added the status: next-release Issues that will enter into the next release label May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carloslancha carloslancha

Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Milestone
2.1.5
Development

No branches or pull requests
2 participants
@carloslancha @matuzalemsteles