Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render a button as a dropdown item if no href is passed to an item with default type | Fixes #941 #953

Merged
merged 7 commits into from
May 29, 2018
Merged

Render a button as a dropdown item if no href is passed to an item with default type | Fixes #941 #953

merged 7 commits into from
May 29, 2018

Conversation

carloslancha
Copy link
Contributor

No description provided.

@carloslancha carloslancha changed the title SF | Fixes #941 Render a button as a dropdown item if no href is passed to an item with default type | Fixes #941 May 29, 2018
@coveralls
Copy link

coveralls commented May 29, 2018

Pull Request Test Coverage Report for Build 855

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.0004%) to 81.487%

Files with Coverage Reduction New Missed Lines %
packages/clay-dropdown/src/ClayDropdownBase.soy.js 7 79.31%
Totals Coverage Status
Change from base Build 847: 0.0004%
Covered Lines: 5095
Relevant Lines: 5433

💛 - Coveralls

@matuzalemsteles
Copy link
Member

Just started reviewing :)

:octocat: Sent from GH.

Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @carloslancha, When we have a button it does not work very well when we have itemsIconAlignment.

It works if we add to the span of the button icon dropdown-item-indicator.

screen shot 2018-05-29 at 12 20 19

@carloslancha
Copy link
Contributor Author

@matuzalemsteles I'm taking a look but we can't add that class to to the button span, 'cause only should happen in a dropdown, and making it configurable only for that seems overkill for me.

@carloslancha
Copy link
Contributor Author

@matuzalemsteles check this approach please

@matuzalemsteles
Copy link
Member

Just started reviewing :)

:octocat: Sent from GH.

@matuzalemsteles
Copy link
Member

@carloslancha yes, I agree. Sounds good to me.

@matuzalemsteles
Copy link
Member

Merged, thanks!

@matuzalemsteles matuzalemsteles merged commit 9bb4139 into liferay:develop May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants