-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render a button as a dropdown item if no href is passed to an item with default type | Fixes #941 #953
Render a button as a dropdown item if no href is passed to an item with default type | Fixes #941 #953
Conversation
Pull Request Test Coverage Report for Build 855
💛 - Coveralls |
Just started reviewing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @carloslancha, When we have a button it does not work very well when we have itemsIconAlignment
.
It works if we add to the span
of the button icon dropdown-item-indicator
.
@matuzalemsteles I'm taking a look but we can't add that class to to the button span, 'cause only should happen in a dropdown, and making it configurable only for that seems overkill for me. |
@matuzalemsteles check this approach please |
Just started reviewing :) |
@carloslancha yes, I agree. Sounds good to me. |
Merged, thanks! |
No description provided.