Fixes #1392 - Add actionHandler to ClayManagementToolbar #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbalsas
reviewed
Dec 18, 2018
| @@ -5,6 +5,7 @@ | |||
| */ | |||
| {template .render} | |||
| {@param name: string} | |||
| {@param? _handleActionItemClicked: any} | |||
jbalsas
reviewed
Dec 18, 2018
| @@ -42,7 +43,10 @@ | |||
| {param contentRenderer: 'image' /} | |||
| {param disabled: $disabled /} | |||
| {param elementClasses: $classes /} | |||
| {param events: ['itemToggled': $_handleItemToggled ] /} | |||
| {param events: [ | |||
jbalsas
reviewed
Dec 18, 2018
| @@ -116,6 +116,11 @@ class ClayComponent extends Component { | |||
|
|
|||
| const listeners = this.getRawListeners_(eventName); | |||
|
|
|||
| if (this.actionHandler) { | |||
There was a problem hiding this comment.
Should the actionHandler be able to prevent events?
|
We've had an offline conversation about this... the proposal is to move this to a
|
|
Resent #1405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.