Fixes #1392 - Add support for defaultEventHandlers #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 18, 2018 18:38
carloslancha
changed the title
jbalsas
approved these changes
Dec 18, 2018
There was a problem hiding this comment.
Hey @carloslancha, I've just left a small comment, other than that looks good to me, feel free to address it and merge this if makes sense!
|
|
||
| if ( | ||
| listeners.length === 0 && | ||
| (this.defaultEventHandler && !this.defaultEventHandler[handlerName]) |
There was a problem hiding this comment.
I think this would miss the case where we don't have a defaultEventHandler, wouldn't it? Should this be
listeners.length === 0 && (!this.defaultEventHandler || !this.defaultEventHandler[handlerName])There was a problem hiding this comment.
This might be hard to test, because the effect should be negligible and it would require testing implementation... 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.