Fixes #1458 - Re-enable and update generator-metal-clay tests #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carloslancha: I changed base from "master" to "develop". |
|
This sounds good to me, I do not remember why we deactivated the tests, but I do not see any problem reactivating them. I would say the same comment I put on #1454 so we can move on. |
wincent
changed the title
These were disabled in 2017 in commit 844f56f without explanation. I want to propose a change to the generator, so I've made the tweaks necessary here to get these tests running and passing again. Tested with `yarn test`. Related: https://issues.liferay.com/browse/IFI-420
|
@matuzalemsteles: This one should be ready to go now too; I created #1458 and linking to it from commit message and the PR title. |
matuzalemsteles
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were disabled in 2017 in commit 844f56f without explanation. I want to propose a change to the generator, so I've made the tweaks necessary here to get these tests running and passing again.
Tested with
yarn test.Related: https://issues.liferay.com/browse/IFI-420