Fixes #1457 - Refer to Yarn consistently in Clay README #1454
Conversation
|
hey @gregory-bretall, Thanks for that. But only a small change, when they are issues of Jira we open a issue in Github and we refer to this issue in the Jira for track, in the commit message we refer to the issue of Github. Can you create an issue for this and if possible do the same with the other PR? Then I think we'll be ready to give merged. Please let me know if this got too confusing 😅. |
I think that makes sense. Let me tell you how I think it works and you can tell me if I understood correctly:
It sounds like it is mostly a uni-directional link from Jira to GitHub, not a bi-directional one in both ways. |
|
Yes, that's correct.
About the description, I see no problem in refer to issue in Jira. We do not have a pattern on that part, feel free. |
wincent
changed the title
The Clay README instructs people to install and use Yarn, and we ship with a yarn.lock, but we don't consistently use `yarn` in the commands that we show in the README; this commit fixes that for consistency. Tested the commands manually to make sure they all run as intended. Related: https://issues.liferay.com/browse/IFI-421
|
Ok @matuzalemsteles, I just created a related issue and updated the PR title and commit message to refer to the issue. |
wincent
changed the title
|
Thanks @wincent!! |
The Clay README instructs people to install and use Yarn, and we ship with a yarn.lock, but we don't consistently use
yarnin the commands that we show in the README; this commit fixes that for consistency.Tested the commands manually to make sure they all run as intended.
Related: https://issues.liferay.com/browse/IFI-421