-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Info button and Info Panel to page demos #523
Conversation
Just started reviewing :) |
Hey @pat270 there were some missing things in Management Toolbar docs about info button, I talked with them and it's already added:
So, could you please add the info button examples to the Management Toolbar demos in both default and active states? Also, just to avoid errors, could you replace the circle info icon in the items in List View Templates demo page with anyone else? Each element shouldn't have that action and can be confusing. This is the part I'm talking about: Thx!! |
cc71c51
to
83e522b
Compare
Hey Carlos, Subnav (blue bar under default management bar) needs more work. I just saw some things I haven't seen before in the Search in Management Bar Invision document. |
Just started reviewing :) |
Just as a reminder: we're waiting to add needed work to resolve what Victor commented in the doc about calculate the maximum width for the filter button before merging this pr. |
…pposite sign, generally used for null values so Sass doesn't output value `-null`
…ld push over content based on menu size and position of content on the page Update: Side Navigation JS `.sidenav-menu` should adjust if `.sidenav-content` becomes taller than the menu Update: Side Navigation JS `clearStyle` should accept multiple css properties New: Side Navigation JS added option to configure `heightType`, a full height `sidenav-menu` that is as tall as the document, and deprecate `equalHeight` option
…dn't reset `padding-left` and `padding-right`, `.sidenav-menu-slider` should have `overflow: visible` when fully open
…Panel on test pages Card, Table, List View
…nu demos to `expand` because it's confusing
…gement Bar Primary and Info Panel
…position of Info Button on Management Bar Primary
…, `$nav-btn-padding-y` and buttons in Nav should inherit padding-x from `.btn-sm`
…-nav-expand`, `.nav-item-expand`, `.nav-item-shrink` to help with horizontal sizing of various items in Navbar
I added the truncating text thing. It was the Select All button not the Filter and Order dropdown. |
Pull Request Test Coverage Report for Build 293
💛 - Coveralls |
Just started reviewing :) |
Resent #612 |
This updates side-navigation.js and markup so https://lexicondesign.io/docs/patterns/Sidebar/infopanel.html can be implemented.