Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Info button and Info Panel to page demos #523

Closed
wants to merge 13 commits into from

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Feb 8, 2018

This updates side-navigation.js and markup so https://lexicondesign.io/docs/patterns/Sidebar/infopanel.html can be implemented.

@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@carloslancha
Copy link
Contributor

Hey @pat270 there were some missing things in Management Toolbar docs about info button, I talked with them and it's already added:

  • Info button must appear in management toolbar active state
  • Clarified that info button is not part of the item actions (dropdown and quick menu).

So, could you please add the info button examples to the Management Toolbar demos in both default and active states?

Also, just to avoid errors, could you replace the circle info icon in the items in List View Templates demo page with anyone else? Each element shouldn't have that action and can be confusing. This is the part I'm talking about:
captura de pantalla 2018-02-09 a las 7 20 56

Thx!!

@pat270 pat270 force-pushed the clay-481 branch 2 times, most recently from cc71c51 to 83e522b Compare February 9, 2018 22:30
@pat270
Copy link
Member Author

pat270 commented Feb 9, 2018

Hey Carlos,
I changed the things you wanted. The only thing I didn't add was the Info button in the default state. It breaks to a new line in small screens. I don't think the Lexicon guys accounted for that extra space.

Subnav (blue bar under default management bar) needs more work. I just saw some things I haven't seen before in the Search in Management Bar Invision document.

@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@carloslancha
Copy link
Contributor

Just as a reminder: we're waiting to add needed work to resolve what Victor commented in the doc about calculate the maximum width for the filter button before merging this pr.

…pposite sign, generally used for null values so Sass doesn't output value `-null`
…ld push over content based on menu size and position of content on the page

Update: Side Navigation JS `.sidenav-menu` should adjust if `.sidenav-content` becomes taller than the menu

Update: Side Navigation JS `clearStyle` should accept multiple css properties

New: Side Navigation JS added option to configure `heightType`, a full height `sidenav-menu` that is as tall as the document, and deprecate `equalHeight` option
…dn't reset `padding-left` and `padding-right`, `.sidenav-menu-slider` should have `overflow: visible` when fully open
…nu demos to `expand` because it's confusing
…position of Info Button on Management Bar Primary
…, `$nav-btn-padding-y` and buttons in Nav should inherit padding-x from `.btn-sm`
…-nav-expand`, `.nav-item-expand`, `.nav-item-shrink` to help with horizontal sizing of various items in Navbar
@pat270
Copy link
Member Author

pat270 commented Feb 20, 2018

I added the truncating text thing. It was the Select All button not the Filter and Order dropdown.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 293

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.184%

Totals Coverage Status
Change from base Build 292: 0.0%
Covered Lines: 4390
Relevant Lines: 4624

💛 - Coveralls

@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@carloslancha
Copy link
Contributor

Resent #612

@pat270 pat270 deleted the clay-481 branch April 17, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants