CONTRIBUTING.md: modern feature bit assignment. #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustyrussell
commented
Sep 11, 2023
rustyrussell
commented
- Put it in the PR title so everyone can see.
- Deploy with +100 while it's still unratified, in case it changes.
1. Put it in the PR title so everyone can see. 2. Deploy with +100 while it's still unratified, in case it changes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
carlaKC
approved these changes
Sep 12, 2023
|
Should we extend that recommendation to messages and tlv fields introduced by experimental features? This isn't strictly necessary: an implementation that wants to support both the experimental version and the official version could encode/decode messages and tlvs differently depending on what feature was negotiated (the experimental feature bit or the official one). But it's a bit cumbersome (at least in eclair we'd rather use separate messages for the experimental version of the feature). Maybe at least worth mentioning that this is a concern that implementers should worry about? |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.