BOLT 4: don't allow a "fee" for the final node. #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently made a cut & paste bug with the protocol tests, and paid an HTLC of amount 100M msat, but with only a 1M msat `amt_to_forward` in the hop_data. To my surprise, it was accepted. This is because we allow overpaying the routing fee (considered 0 for the final hop). This doesn't make sense for the final hop: anything but exact equality implies a bug, or that the previous node took the wrong amount from the payment. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
|
We're also currently using Nothing blocking on our side to merge this change, ACK |
|
ACK |
t-bast
approved these changes
Dec 9, 2019
cfromknecht
approved these changes
Dec 9, 2019
|
Given all three acks, and the meeting comment that this is a "no-brainer", I'm merging now. |
t-bast
pushed a commit
that referenced
this pull request
Jan 8, 2020
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Jan 15, 2020
* Final recipient should not collect a fee: see lightning/bolts#711 * Fix Sphinx small privacy leak: see lightning/bolts#697
niftynei
pushed a commit
to niftynei/lightning-rfc
that referenced
this pull request
Jan 28, 2020
Update a requirement that was missed in lightning#711
niftynei
pushed a commit
to niftynei/lightning-rfc
that referenced
this pull request
Feb 17, 2020
Update a requirement that was missed in lightning#711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently made a cut & paste bug with the protocol tests, and
paid an HTLC of amount 100M msat, but with only a 1M msat
amt_to_forwardin the hop_data. To my surprise, it was accepted.
This is because we allow overpaying the routing fee (considered 0
for the final hop). This doesn't make sense for the final hop: anything
but exact equality implies a bug, or that the previous node took the
wrong amount from the payment.
Signed-off-by: Rusty Russell rusty@rustcorp.com.au