Update to OpenTracing 1.5.0. #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
approved these changes
Jun 21, 2018
src/dynamic_load.cpp
Outdated
| const void** error_category, | ||
| void** tracer_factory) { | ||
| if (std::strcmp(opentracing_version, OPENTRACING_VERSION) != 0) { | ||
| static int OpenTracingMakeTracerFactoryFct(const char* opentracing_version, |
There was a problem hiding this comment.
Is this making a factory-factory? Maybe a comment would help parse the name, then.
There was a problem hiding this comment.
I'll reword it. As part of adding dynamic loading support for Windows (opentracing/opentracing-cpp#93), we had to change OpenTracingMakeTracerFactory from a function to a variable; so it's really there just to distinguish the function name from the variable name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.