Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for OpenTracing1.5.0 #23

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Update for OpenTracing1.5.0 #23

merged 1 commit into from
Jun 27, 2018

Conversation

gabrielkay
Copy link
Contributor

@rnburn
Copy link
Owner

rnburn commented Jun 26, 2018

Thanks. Looks good.

Could you just run scripts/run_clang_format.sh ?

@gabrielkay
Copy link
Contributor Author

Is this what you meant?

@rnburn
Copy link
Owner

rnburn commented Jun 27, 2018 •
edited
Loading

Yep, I think the only thing missing is the bazel commit here and here; then it should be good to merge.

@gabrielkay
Copy link
Contributor Author

I put in the latest commit hash

@rnburn
Copy link
Owner

rnburn commented Jun 27, 2018

👍 - thank you

@rnburn rnburn merged commit a1c065c into rnburn:master Jun 27, 2018
@rnburn
Copy link
Owner

rnburn commented Jun 27, 2018

Maybe you have a pre-1.5 build of opentracing installed that doesn't have OPENTRACING_ABI_VERSION installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielkay @rnburn