Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test dependencies and fix github actions cache. #21

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Update test dependencies and fix github actions cache. #21

merged 1 commit into from
Jan 6, 2023

Conversation

apollo13
Copy link
Contributor

@apollo13 apollo13 commented Jan 6, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023 •
edited
Loading

Codecov Report

Merging #21 (16d5adc) into main (188d1fb) will not change coverage.
The diff coverage is n/a.

❗ Current head 16d5adc differs from pull request most recent head f987c50. Consider uploading reports for the commit f987c50 to get more accurate results

@@            Coverage Diff             @@
##              main       #21    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            9         3     -6     
  Lines          418       158   -260     
  Branches        48        35    -13     
==========================================
- Hits           418       158   -260
Impacted Files Coverage Δ
tests/test_file_helpers.py
tests/test_files.py
tests/test_goodconf.py
tests/utils.py
tests/test_django.py
tests/test_initial.py

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

apollo13
apollo13 commented Jan 6, 2023
View reviewed changes
.github/workflows/test.yml
@@ -27,15 +27,15 @@ jobs:
- uses: actions/cache@v3
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ matrix.python }}-${{ hashFiles('setup.cfg') }}
key: ${{ runner.os }}-pip-${{ matrix.python }}-${{ hashFiles('pyproject.toml') }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to change that before, now setup.cfg is static and rather useless.

pyproject.toml Outdated
@@ -54,7 +54,7 @@ default_section = "THIRDPARTY"
known_first_party = "goodconf"

[tool.pytest.ini_options]
addopts = "--cov"
addopts = "--cov=goodconf --cov-branch"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cover only goodconf instead of tests as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having coverage on tests will show you if a test you wrote isn't being executed for some reason. Wouldn't that be helpful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhm good point, will push (although depending on whether features are activated via python version we might have to combine coverage output at some point :D)

@apollo13 apollo13 marked this pull request as ready for review January 6, 2023 19:08
@apollo13 apollo13 changed the title Don't exclude tests in coverage. Update test dependencies and fix github actions cache. Jan 6, 2023
@apollo13 apollo13 mentioned this pull request Jan 6, 2023
Merged
@ipmb ipmb merged commit d0979ae into lincolnloop:main Jan 6, 2023
@apollo13 apollo13 deleted the no-test-coverage branch January 12, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipmb ipmb ipmb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apollo13 @codecov-commenter @ipmb