Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comments to TOML output. Fixes #20. #22

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

apollo13
Copy link
Contributor

@apollo13 apollo13 commented Jan 6, 2023

The output is not perfect, let me know if you have style improvements that you want to see.

Also neither of the current dumpers supports comments in nested models.

@apollo13 apollo13 force-pushed the toml-comments branch 2 times, most recently from bce6692 to c54c420 Compare January 6, 2023 19:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #22 (bce6692) into main (188d1fb) will decrease coverage by 0.23%.
The diff coverage is 93.75%.

❗ Current head bce6692 differs from pull request most recent head c06659e. Consider uploading reports for the commit c06659e to get more accurate results

@@             Coverage Diff             @@
##              main      #22      +/-   ##
===========================================
- Coverage   100.00%   99.76%   -0.24%     
===========================================
  Files            9        9              
  Lines          418      431      +13     
  Branches        48       50       +2     
===========================================
+ Hits           418      430      +12     
- Partials         0        1       +1     
Impacted Files Coverage Δ
goodconf/__init__.py 99.23% <90.00%> (-0.77%) ⬇️
tests/test_goodconf.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ipmb
Copy link
Member

ipmb commented Jan 6, 2023

Any thoughts on why the test coverage dropped?

@apollo13
Copy link
Contributor Author

apollo13 commented Jan 6, 2023

Could you merge #21, then I will retry after rebasing.

@apollo13
Copy link
Contributor Author

apollo13 commented Jan 6, 2023

I had missing branch coverage :) (did not test a missing docstring)

@ipmb ipmb merged commit 993d745 into lincolnloop:main Jan 6, 2023
@apollo13 apollo13 deleted the toml-comments branch January 12, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants