Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name.lastname@gmail.com parsed as 2 urls #13

Open
ddosoff opened this issue Dec 18, 2016 · 6 comments
Open

name.lastname@gmail.com parsed as 2 urls #13

ddosoff opened this issue Dec 18, 2016 · 6 comments

Comments

@ddosoff
Copy link

ddosoff commented Dec 18, 2016

name.lastname@gmail.com parsed as:

  1. http://name.lastname/
  2. http://gmail.com/
@davidthemarsh
Copy link

I am also seeing this - are there plans to fix it?

@kodjobaah
Copy link

seeing the same problem as @davidthemarsh.

@worpet
Copy link

worpet commented May 3, 2017

I am impacted by this also. Dot containing emails are much more common than I had realized.

@tzuhanjan
Copy link
Contributor

Hmm this is a greedy evaluator, so it matches whatever completes a url first. What should be the correct behavior in this case in your opinions? Should it be one url as name.lastname@gmail.com with an identifier saying that the URL is an email?

@worpet
Copy link

worpet commented May 22, 2017

@tzuhanjan: Expected behavior for me would be "name.lastname@gmail.com" is detected as a single Url with host gmail.com and username name.lastname.

@capnbab
Copy link

capnbab commented Oct 12, 2017

@tzuhanjan Also having this issue. I agree with @worpet, it would be ideal if "name.lastname@gmail.com" was detected as a URL with host gmail.com and username name.lastname. For my use case, I need to exclude hits that look like pure e-mail addresses. So after detecting, I only include where url.getUsername().isEmpty(). This breaks for me on any e-mail address with a dot in the local part.

pgalbraith added a commit to pgalbraith/URL-Detector that referenced this issue Sep 22, 2018
cstroe pushed a commit to cosmincloud/URL-Detector that referenced this issue Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants