Fixes for issues 12, 13, 15, 16 & 24 #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undsException when input string contains the sub-string "//:@."
…undsException when input string contains the sub-string "//:@."
…'http://user:pass@host.com host.com' as input string Updated url-detector.processColon to set length to 0 when readUserPass(length) is true. All unit tests passed after this update.
…upstream-issue-16
Previously the domain read routine assumed all hope was lost if domain could not be read, but this decision should be made by the caller ... maybe there is another assumption the caller could make that would work out.
So the obvious downside is the risk of actually getting into an endless loop but I think the risk is worth it. If the code is solid then this is not possible, so I'd rather address those cases as (if?) they come up, instead causing false failures like the case in this issue.
Add missing plugin versions and specify file encoding.
pgalbraith
changed the title
|
Closing as I shouldn't have mixed so many fixes in one PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for several issues raised on this repository ... I'm kind of assuming that this library has been orphaned and nobody is maintain it any more?