Make generated jar files read-only after creation #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cckroets
reviewed
Jun 30, 2022
In a future version of Android(^1), dynamically loaded dex files cannot be writable to the loading process. This affects Mockito in instrumentation tests, as dex bytecode is generated and loaded at runtime. ^1: https://android-review.googlesource.com/q/topic:ro_java_dcl
|
@cckroets this is the only change currently planned that would affect dexmaker (at least for now). A release would be appreciated! |
0xf104a
pushed a commit
to MilkyWayOS/android_frameworks_base
that referenced
this pull request
Feb 24, 2024
To fix dynamically loaded dex files cannot be writable issue when target 34. Upstream: linkedin/dexmaker#181 Platform: https://r.android.com/2128792 Bug: 260441791 Test: Gradle Sync Test: Run Tests Change-Id: I532af3c8ac4198a94779b592075295e212ffe77f
elpaablo
pushed a commit
to elpaablo/frameworks_base
that referenced
this pull request
Oct 19, 2024
To fix dynamically loaded dex files cannot be writable issue when target 34. Upstream: linkedin/dexmaker#181 Platform: https://r.android.com/2128792 Bug: 260441791 Test: Gradle Sync Test: Run Tests Change-Id: I532af3c8ac4198a94779b592075295e212ffe77f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a future version of Android(^1), dynamically loaded dex files cannot be writable to the loading process. This affects Mockito in instrumentation tests, as dex bytecode is generated and loaded at runtime.
I also took the liberty and updated the gradle project and dependencies. Please let me know if this is unwanted and I can remove those changes.
^1: https://android-review.googlesource.com/q/topic:ro_java_dcl