Add the framework for package-specific settings. #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Mar 12, 2018
| testProjectDir.buildFile << """\ | ||
| | plugins { | ||
| | id 'com.linkedin.python-pex' | ||
| | } | ||
| | version = '1.0.0' | ||
| | version = '1.0.0-MPDEP' |
| Map<String, String> environment | ||
|
|
||
| @Input | ||
| @Optional |
There was a problem hiding this comment.
Why is it optional? It has a default, would it be required?
| public class DefaultEnvironmentMerger implements EnvironmentMerger { | ||
| @Override | ||
| public Map<String, String> mergeEnvironment(Map<String, String> target, Map<String, String> source) { | ||
| if (source != null) { |
There was a problem hiding this comment.
I think you probably want to make a new map, and insert all of the non-null values into it. This will change the origional I feel will cause problems down the road.
| * | ||
| * @param <T> Type of the object that represents package information. | ||
| */ | ||
| public interface PackageSettings<T> { |
There was a problem hiding this comment.
The intent is to have a generic type for future development. No need to change T in this interface when we change the package information type.
zvezdan
force-pushed
the
package-specific-settings
branch
from
154094e to
9ec4b68
Compare
Add the interface and the default implementation for package specific settings. Use the framework calls in pip install and build wheel tasks.
zvezdan
force-pushed
the
package-specific-settings
branch
from
9ec4b68 to
3da7f6e
Compare
ghost
approved these changes
Mar 13, 2018
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the interface and the default implementation for package specific
settings. Use the framework calls in pip install and build wheel tasks.