Adding Wheel Filtering Support #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, wheels should be skipped from caching. This is because we don't want to re-use dependencies that can change, as they won't be re-built afterwards.
|
Can you explain more why do we need this change? How do I know that something shouldn't be cached? |
|
With #196 we don't need this. This was intended to make it so that changing (SNAPSHOT, DEV, etc) packages don't get stored into a cache, and not rebuilt. But with #196, @zvezdan make it where we can check if the dependency should be built instead of using a cached value, so I closed the PR since we don't need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, wheels should be skipped from caching. This is because we
don't want to re-use dependencies that can change, as they won't be
re-built afterwards.