-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update linkerd/dev from v30 to v44 #1895
Conversation
olix0r
commented
Dec 5, 2024
•
edited
Loading
edited
- docker.io/library/golang from 1.22 to 1.23
- gotestsum from 0.4.2 to 1.12.0
- protoc-gen-go from 1.28.1 to 1.35.2
- protoc-gen-go-grpc from 1.2 to 1.5.1
- docker.io/library/rust from 1.76.0 to 1.83.0
- cargo-deny from 0.14.11 to 0.16.3
- cargo-nextest from 0.9.67 to 0.9.85
- cargo-tarpaulin from 0.27.3 to 0.31.3
- just from 1.24.0 to 1.37.0
- yq from 4.33.3 to 4.44.5
- markdownlint-cli2 from 0.10.0 to 0.15.0
- shellcheck from 0.9.0 to 0.10.0
- actionlint from 1.6.26 to 1.7.4
- protoc from 3.20.3 to 29.0
- step from 0.25.2 to 0.28.2
- kubectl from 1.29.2 to 1.31.3
- k3d from 5.6.0 to 5.7.5
- k3s image shas
- helm from 3.14.1 to 3.16.3
- helm-docs from 1.12.0 to 1.14.2
0c0c65e
to
ab922bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, FWIW.
steps: | ||
- uses: linkerd/dev/actions/setup-tools@v44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup-tools should be substantially more lightweight than loading the whole dev container
- name: On create | ||
run: | | ||
.devcontainer/on-create.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't necessary to use shellcheck.
@@ -3,22 +3,20 @@ name: validate | |||
on: | |||
pull_request: | |||
paths: | |||
- .github/workflows/validate.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures that changes to the workflow exercise the workflow.
@@ -3,24 +3,19 @@ name: install | |||
on: | |||
pull_request: | |||
paths: | |||
- .github/workflows/install.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensures changes to the workflow exercise the workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the dev tools!
Co-authored-by: Flynn <kflynn@users.noreply.github.com> Signed-off-by: Ivan Porta <gtrekter@MacBook-Pro-M4.local>