-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update linkerd/dev from v30 to v44 #1895
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,24 +3,19 @@ name: install | |
on: | ||
pull_request: | ||
paths: | ||
- .github/workflows/install.yml | ||
- Makefile | ||
- run.linkerd.io/public/install* | ||
|
||
jobs: | ||
lint: | ||
name: Lint install script | ||
runs-on: ubuntu-latest | ||
container: | ||
image: ghcr.io/linkerd/dev:v39 | ||
options: --user root | ||
steps: | ||
- uses: linkerd/dev/actions/setup-tools@v44 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. setup-tools should be substantially more lightweight than loading the whole dev container |
||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
|
||
- name: On create | ||
run: | | ||
.devcontainer/on-create.sh | ||
Comment on lines
-20
to
-22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't necessary to use shellcheck. |
||
|
||
- name: Lint install script | ||
run: | | ||
make shellcheck | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,22 +3,20 @@ name: validate | |
on: | ||
pull_request: | ||
paths: | ||
- .github/workflows/validate.yml | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This ensures that changes to the workflow exercise the workflow. |
||
- linkerd.io/** | ||
|
||
jobs: | ||
linkerd_io: | ||
name: Validate generated HTML | ||
runs-on: ubuntu-latest | ||
container: | ||
image: ghcr.io/linkerd/dev:v39 | ||
options: --user root | ||
steps: | ||
- uses: linkerd/dev/actions/setup-tools@v44 | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
|
||
- name: On create | ||
run: | | ||
.devcontainer/on-create.sh | ||
run: .devcontainer/on-create.sh | ||
|
||
- name: Lint markdown | ||
run: | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensures changes to the workflow exercise the workflow.