Skip to content

Commit

Permalink
fix: [M3-7208] Prevent forwarding the title prop to the markup (#9739)
Browse files Browse the repository at this point in the history
* Prevent forwarding the title prop to the html

* Added changeset: Removed `title` prop forwarding on Modals/Dialogs

* Address feedback
  • Loading branch information
abailly-akamai authored Oct 3, 2023
1 parent 425ac20 commit cfbc69b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-9739-fixed-1696019997998.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

Removed `title` prop forwarding on Modals/Dialogs ([#9739](https://github.com/linode/manager/pull/9739))
2 changes: 1 addition & 1 deletion packages/manager/src/components/Dialog/Dialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export const Dialog = (props: DialogProps) => {
};

const StyledDialog = styled(_Dialog, {
shouldForwardProp: (prop) => isPropValid(['fullHeight'], prop),
shouldForwardProp: (prop) => isPropValid(['fullHeight', 'title'], prop),
})<DialogProps>(({ theme, ...props }) => ({
'& .MuiDialog-paper': {
height: props.fullHeight ? '100vh' : undefined,
Expand Down

0 comments on commit cfbc69b

Please sign in to comment.