fix: [M3-7208] Prevent forwarding the title prop to the markup #9739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
requested review from
cpathipa and
cliu-akamai
and removed request for
a team
mjac0bs
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
🎉 Thank you for making this change!
I was able to take a screenshot of a dialog for the first time without the tooltip popping up in the middle of it.
Also confirmed that the title was still rendering in dialogs as expected and we still have an ariaLabeledBy prop with the title of the dialog.
bnussman-akamai
approved these changes
Oct 3, 2023
bnussman-akamai
added
Approved
abailly-akamai
force-pushed
the
fix-M3-7208
branch
from
cf245dc
to
b2729e3
Compare
cpathipa
approved these changes
Oct 3, 2023
abailly-akamai
force-pushed
the
fix-M3-7208
branch
from
b2729e3
to
3417081
Compare
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
You've been annoyed by this on our modals?
Look no further, this fix is for you.
The title prop on our modals creates more trouble than it's worth. It adds html tooltip (a proper HTML
titlefeature) that follows you around and often obfuscate content or distracts the user.It does not add any particular accessibility feature (known to me) and does not seem to be standard at all:
https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/dialog/
We already have the necessary features described in the accessibility standards docs so there's no need to continue defining them and require them on those components.
Major Changes 🔄
List highlighting major changes
How to test 🧪
titletooltip is gone (usually after mouse pointing in the same spot for a couple seconds