refactor: [M3-8459] - Remove patch-package package
#10800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
carrillo-erik and
coliu-akamai
and removed request for
a team
bnussman-akamai
added
the
Dependencies
|
Coverage Report: ✅ |
coliu-akamai
approved these changes
Aug 19, 2024
Comment on lines
-62
to
-63
| - **/patches** | ||
| - patches applied to dependencies via patch-package |
There was a problem hiding this comment.
Unrelated to this pr, but I noticed that this doc could use an update in general, maybe in a separate ticket:
- there are now four packages within the 'packages' directory
- inside the manager package, directories like /scripts don't exist anymore (seems like scripts was moved outside the packages directory, unless that's different?)
- events.ts and eventsPolling.ts are no longer files in manager/src's root
probably some others but those I just saw at a quick glance
There was a problem hiding this comment.
Good call, I'll make a ticket for those doc updates
carrillo-erik
approved these changes
Aug 21, 2024
bnussman-akamai
added
Approved
coliu-akamai
pushed a commit
to coliu-akamai/manager
that referenced
this pull request
Aug 22, 2024
* remove `patch-package` package * Added changeset: Remove `patch-package` package --------- Co-authored-by: Banks Nussman <banks@nussman.us>
coliu-akamai
pushed a commit
to coliu-akamai/manager
that referenced
this pull request
Aug 22, 2024
* remove `patch-package` package * Added changeset: Remove `patch-package` package --------- Co-authored-by: Banks Nussman <banks@nussman.us>
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
patch-packagepackage 📦How to test 🧪
As an Author I have considered 🤔