Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [M3-8459] - Remove patch-package package #10800

Merged
merged 2 commits into from
Aug 21, 2024
Merged

refactor: [M3-8459] - Remove patch-package package #10800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a35a40d
remove `patch-package` package
bnussman Aug 19, 2024
dbb6111
Added changeset: Remove `patch-package` package
bnussman Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/development-guide/01-repository-structure.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ A few notable directories in the root level of the manager package:
- end-to-end tests
- **/e2e**
- old end-to-end tests [deprecated]
- **/patches**
- patches applied to dependencies via patch-package
Comment on lines -62 to -63
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this pr, but I noticed that this doc could use an update in general, maybe in a separate ticket:

  • there are now four packages within the 'packages' directory
  • inside the manager package, directories like /scripts don't exist anymore (seems like scripts was moved outside the packages directory, unless that's different?)
  • events.ts and eventsPolling.ts are no longer files in manager/src's root

probably some others but those I just saw at a quick glance

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'll make a ticket for those doc updates

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created M3-8464

- **/public**
- assets, fonts, HTML, and third-party JS
- **/scripts**
Expand Down
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"devDependencies": {
"husky": "^3.0.1",
"npm-run-all": "^4.1.5",
"patch-package": "^7.0.0",
"postinstall": "^0.6.0",
"typescript": "^5.4.5"
},
Expand All @@ -19,7 +18,6 @@
"cost-of-modules": "yarn global add cost-of-modules && cost-of-modules --less --no-install --include-dev",
"install:all": "yarn install --frozen-lockfile",
"upgrade:sdk": "yarn workspace @linode/api-v4 version --no-git-tag-version --no-commit-hooks && yarn workspace linode-manager upgrade @linode/api-v4",
"postinstall": "echo \"Skipping Patching: yarn workspaces run postinstall && patch-package\"",
"build:sdk": "yarn workspace @linode/api-v4 build",
"build:validation": "yarn workspace @linode/validation build",
"build": "yarn build:validation && yarn build:sdk && yarn workspace linode-manager build",
Expand Down
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10800-tech-stories-1724094117438.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tech Stories
---

Remove `patch-package` package ([#10800](https://github.com/linode/manager/pull/10800))
2 changes: 0 additions & 2 deletions packages/manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
"markdown-it": "^12.3.2",
"md5": "^2.2.1",
"notistack": "^3.0.1",
"patch-package": "^7.0.0",
"qrcode.react": "^0.8.0",
"ramda": "~0.25.0",
"react": "^18.2.0",
Expand Down Expand Up @@ -87,7 +86,6 @@
"zxcvbn": "^4.4.2"
},
"scripts": {
"postinstall": "patch-package",
"start": "concurrently --raw \"vite\" \"tsc --watch --preserveWatchOutput\"",
"start:expose": "concurrently --raw \"vite --host\" \"tsc --watch --preserveWatchOutput\"",
"start:ci": "yarn serve ./build -p 3000 -s --cors",
Expand Down
20 changes: 0 additions & 20 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11041,26 +11041,6 @@ parseurl@~1.3.3:
resolved "https://registry.yarnpkg.com/parseurl/-/parseurl-1.3.3.tgz#9da19e7bee8d12dff0513ed5b76957793bc2e8d4"
integrity sha512-CiyeOxFT/JZyN5m0z9PfXw4SCBJ6Sygz1Dpl0wqjlhDEGGBP1GnsUVEL0p63hoG1fcj3fHynXi9NYO4nWOL+qQ==

patch-package@^7.0.0:
version "7.0.2"
resolved "https://registry.yarnpkg.com/patch-package/-/patch-package-7.0.2.tgz#c01589bb6964854b5210506a5845d47900641f5a"
integrity sha512-PMYfL8LXxGIRmxXLqlEaBxzKPu7/SdP13ld6GSfAUJUZRmBDPp8chZs0dpzaAFn9TSPnFiMwkC6PJt6pBiAl8Q==
dependencies:
"@yarnpkg/lockfile" "^1.1.0"
chalk "^4.1.2"
ci-info "^3.7.0"
cross-spawn "^7.0.3"
find-yarn-workspace-root "^2.0.0"
fs-extra "^9.0.0"
klaw-sync "^6.0.0"
minimist "^1.2.6"
open "^7.4.2"
rimraf "^2.6.3"
semver "^7.5.3"
slash "^2.0.0"
tmp "^0.0.33"
yaml "^2.2.2"

patch-package@^8.0.0:
version "8.0.0"
resolved "https://registry.yarnpkg.com/patch-package/-/patch-package-8.0.0.tgz#d191e2f1b6e06a4624a0116bcb88edd6714ede61"
Expand Down
Loading