Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8308] - Add bucket rate limit info to Object Storage Bucket Details drawer #10821

Conversation

harsh-akamai
Copy link
Contributor

Description 📝

Add bucket rate limit info to bucket details drawer

Changes 🔄

In Bucket Details drawer:

  • For legacy buckets, add the bucket rate limit of 750 RPS
  • For E2/E3 buckets, add bucket rate limit table

Target release date 🗓️

N/A

Preview 📷

Before Legacy Bucket E2&E3 Bucket
image 04_47_08 04_47_24

How to test 🧪

Prerequisites

  • Test all components for ObjectStorage buckets by toggling the OBJ Gen2 feature flag in dev environment

Verification steps

  • Turn on MSW
  • Go to Object Storage landing page
  • On opening a bucket's Details drawer, you should find a bucket rate limit table for E2 and E3 buckets, and a bucket rate limit of 750RPS text for legacy buckets

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@harsh-akamai harsh-akamai self-assigned this Aug 23, 2024
@harsh-akamai harsh-akamai requested a review from a team as a code owner August 23, 2024 11:53
@harsh-akamai harsh-akamai requested review from hana-linode and carrillo-erik and removed request for a team August 23, 2024 11:53
Copy link

github-actions bot commented Aug 23, 2024

Coverage Report:
Base Coverage: 82.62%
Current Coverage: 82.62%

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 23, 2024
@hana-linode hana-linode added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 23, 2024
@harsh-akamai harsh-akamai force-pushed the feature/M3-8308-add-bucket-rate-limit-to-bucket-details-drawer branch from 7dfa23a to 09834ff Compare August 26, 2024 04:41
@jaalah-akamai jaalah-akamai merged commit 218b009 into linode:develop Aug 27, 2024
19 checks passed
@harsh-akamai harsh-akamai deleted the feature/M3-8308-add-bucket-rate-limit-to-bucket-details-drawer branch August 28, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Object Storage Gen2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants