Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [M3-8308] - Add bucket rate limit info to Object Storage Bucket Details drawer #10821

Merged
merged 4 commits into from
Aug 27, 2024
Merged

upcoming: [M3-8308] - Add bucket rate limit info to Object Storage Bucket Details drawer #10821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ea7805
upcoming: [M3-8308] - Add bucket rate limit info to bucket details dr…
harsh-akamai Aug 23, 2024
09834ff
Added changeset: Add bucket rate limit info to Object Storage Bucket …
harsh-akamai Aug 23, 2024
66f31ae
refactor: [8308] - typo fix
harsh-akamai Aug 26, 2024
6172b39
refactor: [M3-8308] - Renamed data-testid
harsh-akamai Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10821-upcoming-features-1724414057285.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Upcoming Features
---

Add bucket rate limit info to Object Storage Bucket Details drawer ([#10821](https://github.com/linode/manager/pull/10821))
19 changes: 19 additions & 0 deletions packages/manager/src/features/ObjectStorage/BucketLanding/BucketDetailsDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import { truncateMiddle } from 'src/utilities/truncate';
import { readableBytes } from 'src/utilities/unitConversions';

import { AccessSelect } from '../BucketDetail/AccessSelect';
import { BucketRateLimitTable } from './BucketRateLimitTable';

import type {
ACLType,
Expand Down Expand Up @@ -73,6 +74,8 @@ export const BucketDetailsDrawer = React.memo(
);

let formattedCreated;
const showBucketRateLimitTable =
endpoint_type === 'E2' || endpoint_type === 'E3';

try {
if (created) {
Expand Down Expand Up @@ -138,6 +141,22 @@ export const BucketDetailsDrawer = React.memo(
)}
{/* @TODO OBJ Multicluster: use region instead of cluster if isObjMultiClusterEnabled
to getBucketAccess and updateBucketAccess. */}
{
<>
<Typography data-testid="bucketRateLimit" variant="h3">
Bucket Rate Limits
</Typography>
{showBucketRateLimitTable ? (
<BucketRateLimitTable endpointType={endpoint_type} />
) : (
<Typography>
This endpoint type supports up to 750 Requests Per Second(RPS).{' '}
<Link to="#">Understand bucket rate limits</Link>.
</Typography>
)}
</>
}
{<Divider spacingBottom={16} spacingTop={16} />}
{cluster && label && (
<AccessSelect
getAccess={() =>
Expand Down
Loading