Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: [M3-7287] - Add new test for the NodeBalancer Create flow for multiple nodes and multiple configs #10825

Merged
merged 4 commits into from
Sep 10, 2024
Merged

test: [M3-7287] - Add new test for the NodeBalancer Create flow for multiple nodes and multiple configs #10825

merged 4 commits into from
Sep 10, 2024

Conversation

AzureLatte
Copy link
Contributor

@AzureLatte AzureLatte commented Aug 23, 2024 •
edited
Loading

Description 📝

Add new Cypress tests for the NodeBalancer Create flow to test the submission of multiple nodes and multiple configs.

Changes 🔄

  • Add new tests in nodebalancers/nodebalancers-create-in-complex-form.spec.ts

How to test 🧪

yarn cy:run -s "cypress/e2e/core/nodebalancers/nodebalancers-create-in-complex-form.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte self-assigned this Aug 23, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner August 23, 2024 16:00
@AzureLatte AzureLatte requested review from cliu-akamai and removed request for a team August 23, 2024 16:01
@AzureLatte AzureLatte requested a review from a team as a code owner August 23, 2024 16:03
@AzureLatte AzureLatte requested review from jdamore-linode and abailly-akamai and removed request for a team August 23, 2024 16:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 82.62%
Current Coverage: 82.62%

abailly-akamai
abailly-akamai approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passing on my end and code looks good, thx for the improved coverage!

coliu-akamai
coliu-akamai approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed tests pass locally - thanks for added coverage! 🎉

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Sep 10, 2024
@AzureLatte AzureLatte merged commit 66f43b3 into linode:develop Sep 10, 2024
19 checks passed
@AzureLatte AzureLatte deleted the M3-7287 branch September 10, 2024 17:06
This was referenced Sep 13, 2024
Merged
Merged
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Sep 23, 2024
@AzureLatte @nikhagra-akamai
test: [M3-7287] - Add new test for the NodeBalancer Create flow for m…
c1370ce 
…ultiple nodes and multiple configs (linode#10825)

* Add new test for the NodeBalancer Create flow to test the submission of multiple nodes and multiple configs

* Added changeset: Add tests for NodeBalancer Create flow

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliu-akamai coliu-akamai coliu-akamai approved these changes

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@cliu-akamai cliu-akamai Awaiting requested review from cliu-akamai cliu-akamai is a code owner automatically assigned from linode/frontend-sdet

@jdamore-linode jdamore-linode Awaiting requested review from jdamore-linode jdamore-linode is a code owner automatically assigned from linode/frontend

Assignees

@AzureLatte AzureLatte

Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AzureLatte @abailly-akamai @coliu-akamai @mjac0bs