Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.128.0 - release → staging #10935

Merged
merged 69 commits into from
Sep 16, 2024
Merged

Conversation

hkhalil-akamai
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai commented Sep 13, 2024

Cloud Manager [2024-09-16] - v1.128.0

Added:

  • Gravatar sunset banner for existing Gravatar users (#10859)
  • New Marketplace app for September 2024 (#10874)
  • Support for quoted strings in Search v2 (#10894)
  • SelectableTableRow story in Storybook (#10870)
  • DisplayPrice story in Storybook (#10904)
  • CheckoutSummary story in Storybook (#10905)
  • CopyableTextField story and cleaned up components (#10912)
  • Tracking metrics for LD DX Tools AB Test (#10906)

Changed:

  • Restricted access UX for Databases (#10794)
  • Update image related copy as part of Image Service Gen2 (#10835)
  • Disable Region in OS tab for unsupported distributed images and fix helper text positioning (#10848)
  • Avatars for users without Gravatars (#10859)
  • Refactor and improve the User Details page (#10861)
  • Hide Beta price notice for Gecko LA and rename Ga code references to LA (#10896)
  • Lower Events historical data fetching to 7 days (#10899)
  • Update security policy (#10902)
  • "Contact support" links to new support ticket in event messages (#10910)
  • Invalid Tax Id notification (#10928)

Fixed:

  • Helper text copy in NodeBalancer Create form “Algorithm” field (#10855)
  • Regions to be searched by ID when Gecko is enabled (#10871)
  • Weblish line wrapping (#10893)
  • Search queries containing and on Linode Create v2's StackScript tab not being respected (#10894)
  • Typo with toast success notification when updating Reverse DNS (#10895)
  • Linode Migrate Datacenter Started event message referring to the wrong region (#10901)
  • DisplayPrice story crash when Currency component's minimumFractionDigits is negative (#10913)
  • Linode Create v2 not handling deprecated and EOL Images (#10914)
  • API Tokens Table style regression (#10918)
  • Incorrect avatar displaying in Notification Center for a small subset of events (#10923)

Tech Stories:

  • Introduce Mock Service Worker V2 (#10610)
  • Replace lodash set utility function to handle security threat raised by Dependabot (#10814)
  • Remove eventMessages feature flag logic and legacy code (#10839)
  • Refactor useToastNotification async toasts (#10841)
  • Update TypeScript and Vitest to latest (#10843)
  • Remove global error interceptors (#10850)
  • Update Node.js from 18.14 to 20.17 (#10866)
  • Remove placementGroups feature flag and conditional rendering (#10877)
  • Resolve "Incomplete string escape or encoding" codeQL alert in generate-ansibleConfig.ts (#10887)
  • Remove linodeCreateRefactor feature flag (#10921)

Tests:

  • Add Cypress integration test for Secure VMs firewall generation (#10802)
  • Add tests for NodeBalancer Create flow (#10825)
  • Add unit test for LinodeVolumeAddDrawer and E2E test for client library update notices in Create/Attach Volume drawer (#10837)
  • Add new tests for for selecting "All" Scopes (#10852)
  • Add unit tests for NodeBalancerConfigPanel (#10855)
  • Add CY_TEST_ACCOUNT_CACHE_DIR environment variable to enable retrieval of test account cache data (#10867)
  • Allow tests to fall back on cached account data when API request fails (#10867)
  • Add Cypress integration test for Object Storage Gen2: E2 Endpoint (#10879)
  • Add Cypress integration test for Object Storage Gen2: E3 Endpoint (#10880)
  • Add Cypress test for empty Linode landing page and restricted user Linode landing page (#10882)
  • Update region selection helpers to account for upcoming Gecko improvements (#10888)
  • Update remaining Linode Create Cypress tests run against Linode Create v2 (#10889)
  • Add unit tests for SelectableTableRow component (#10890)
  • Clean up feature flag mocks (#10892)
  • Add Cypress test to confirm toast when updating RDNS, add unit tests for RDNS drawers (#10895)
  • Add Cypress integration test for Object Storage Gen2: E1 Endpoint (#10907)
  • Add unit tests for AttachVolumeDrawer component (#10909)
  • Add unit tests for NodeBalancersLanding package (#10911)
  • Support running component tests via CI (#10926)

Upcoming Features:

  • Support Volume Encryption and associated notices in Create/Attach Volume drawer (#10837)
  • Add new CloudPulseDashboardWithFilters component that will be used as a reusable component in service provider pages (#10845)
  • Fix Demo feedback and missing changes across ACLP (#10851)
  • Add conditional client library update required reboot notice to Volume Create page (#10868)
  • Add DBaaS V2 Create enhancements (#10872)
  • Revert the “View Code Snippets” button copy to the original text (#10886)
  • Add “Encrypt Volume” checkbox in Attach Volume drawer (#10909)
  • Update BSE capability for Linodes to be Block Storage Encryption instead of blockstorage_encryption (#10920)

APIv4 [2024-09-16] - v0.126.0

Added:

  • LinodeCapabilities type used for capabilities property of Linode interface (#10920)

Tech Stories:

  • Update vitest to latest (#10843)

Upcoming Features:

  • Change 'bs_encryption_supported' property on Linode object to 'capabilities' (#10837)
  • Add beta API root for CloudPulse endpoints (#10851)

bnussman-akamai and others added 30 commits August 29, 2024 09:57
* update a lot of stuff

* Added changeset: Update TypeScript and Vitest to latest

* Added changeset: Updated vitest to latest

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* initial work

* finish fixing all tsc errors

* fix unit tests

* fix cloudpulse types

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…ted images (#10848)

## Description 📝
Not all Linux Distributions in the Linode Create OS tab support distributed regions. We want to disable a region if the selected OS does not have a distributed capability similar to the Images tab

## Changes  🔄
- Remove specific check for `linodeCreateTab` in `getDisabledRegions` so that any selected image that does not have the `distributed-sites` capability is disabled
- Minor UI positioning fix for distributed helper text w/ region error text

## How to test 🧪
### Prerequisites
(How to setup test environment)
- Ensure your account has the `new-dc-testing`, `new-dc-testing-gecko`, `edge_testing` and `edge_compute` customer tags
- Pull this PR and run it locally pointing to dev API

### Reproduction steps
(How to reproduce the issue, if applicable)
- Checkout `develop` locally while pointing to the dev API
- Go to the Linode Create flow
- Notice that distributed regions are not disabled for unsupported distributed images (no distributed icon, e.g. `Debian 11`)

### Verification steps
(How to verify changes)
- Go to the Linode Create flow and verify the `v1` and `v2` flows for Gecko `Beta` & Gecko `LA/GA`
  - To test Gecko Beta locally, you can add the following to `useFlags.ts`:
  - We do not want to change the LD flag globally since other teams rely on it
  -  ...mockFlags,
      gecko2: {
      enabled: true,
      ga: false
    }
- Verify unsupported distributed regions (no distributed icon, e.g. `Debian 11`)
  - Gecko LA/GA: Regions in the Distributed tab should be disabled with tooltip
  - Gecko Beta: Distributed regions in the single dropdown should be disabled with tooltip
- Verify supported distributed regions (distributed icon, e.g. `Ubuntu 24.04 LTS`)
  - Gecko LA/GA: Regions in the Distributed tab should not be disabled
  - Gecko Beta: Distributed regions in the single dropdown should not be disabled
… prototype pollution security threat (#10814)

* remove usage of omit that depends on lodash

* it is not going

* need to figure out types

* hopefully this is something

* todo: fix all bugs and write all the tests

* write tests - need to debug

* determine if supposed index is actually a valid index

* some path indexing that seems difficult to pursue

* update naming, tests

* remove set from package.json

* add back in some commented out tests

* some cleanup, need to look over everything

* update test cases and comments

* changeset + update tests

* simplify set, remove separate set utility files

* Update packages/manager/src/utilities/formikErrorUtils.ts

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>

* update types + fix tests  @abailly-akamai

---------

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
…'Algorithm' field (#10855)

* fix helper text

* add tests

* update test case descriptions

* changesets

* Update packages/manager/src/features/NodeBalancers/NodeBalancerConfigPanel.test.tsx

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

---------

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
* WIP add MSW preset selection

* WIP

* WIP

* WIP dev tools restyle

* WIP styling

* WIP styling

* WIP Allow presets and content to be set and loaded via dev tool

* Add Production-like and Edge mock regions data

* Add 'Backups' to APIv4 `Capabilities` type

* Rename file

* Allow presets to have a description

* Add populators for region data

* Add account review base preset

* WIP

* Improve styling of dev tool selects

* Space between environment select and util buttons

* WIP Improve MSW save handling

* Slightly improve docs/function names

* WIP Slightly improve mobile layout

* WIP RQ

* WIP React Query

* Handle region availability requests

* WIP event handling, Linode events

* fix units

* fixes & cleanup

* More cleanup

* UI improvements

* placement group handlers part 1

* placement group handlers part 2

* placement group handlers part 3

* wrap up crud operations for PGs

* fix hot reload bug

* Revert "fix hot reload bug"

This reverts commit 494cc4e.

* fix hot reload issue the right way

* completing data for initial cruds

* working on events

* events handling

* store part 1

* update naming coventions

* store part 2

* store part 3

* store part 4: seeds

* store part 5: seeds

* more seeding logic

* regions

* volumes

* crud events part 1

* crud events part 2

* naming conventions - part 1

* naming conventions - part 2

* naming conventions - part 3

* naming conventions - part 4

* unique IDs and utils

* pagination and sorting logic

* light ServiceWorker tool

* region work

* worker tools updates

* code cleanup 1

* code cleanup 2

* code cleanup 3

* code cleanup 4

* moar service worker tool work

* some cleanup and more handlers

* Documentatio part 1

* Documentatio part 2

* Small cleanup

* Added changeset: Introduce Mock Service Worker V2

* Update docs/development-guide/09-mocking-data.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Update docs/development-guide/09-mocking-data.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Update docs/development-guide/09-mocking-data.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Update docs/development-guide/09-mocking-data.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Update docs/development-guide/09-mocking-data.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* TS lint fix

* cleanup and feedback

* Draggable dev tools

* Address feedback

* small cleanup and comments

* file renaming and re-org

* getRoot rename

* fix scroll issue

* fix loading in preview links

* feedback @mjac0bs

* cleanup

* feedback @dwiley-akamai

* Account for react query update

* feedback @coliu-akamai

---------

Co-authored-by: Joe D'Amore <jdamore@linode.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
…0802)

* Add cypress test for generating firewall in Linode create flow

* Add integration test for error encountered during firewall generation

* Added changeset: Secure VMs firewall generation

* Fix integration test (maybe?)

* Fix broken assertion
* Upgrade cypress-axe

* Add initial component testing configuration and setup

* Add a11y and component testing utils

* Allow feature flags to be overridden via `cy.mountWithTheme`

* Add simple BetaChip POC component tests

* Add RegionSelect POC component test

* Add "cy:component" command to root package.json
* upcoming: [M3-8378] - Add form logic to bucket details for bucket rate changes

* Cleanup

* Remove logic pertaining to bucket rate limits - far away from this being implemented

* Revise comment

* Update heading for bucket limit

* Update test

* Unskip tets

* Remove false loading state

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Release v1.127.0 - staging → master
* Replace migration error interceptor with component-level error

* Remove 'verification required' error interceptor

* Added changeset: Remove global error interceptors

* Pre-fill entity ID in support link

* Revert typecheck on APIError
* Initial commit - cleanup!

* moar cleanup and test fix

* cleanup and renaming

* Moar moving things around

* Save progress

* Wrapping up cleaning up NotificationCenter

* final cleanup

* Fix e2e

* Added changeset: Cleanup eventMessages flag logic and legacy code

* feedback @mjac0bs
* initial refactor of user details page

* fix existing cypress tests

* fix faulty cypress test

* add some more unit testing

* Added changeset: Refactor and Improve the User Details Page

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…CLP (#10851)

* upcoming: [DI-20348] - Fixing Feedbacks

* upcoming: [DI-20348] - Fixing empty dependency array

* upcoming: [DI-20348] - Defer placeholder from props

* upcoming: [DI-20357] - Code Refactoring for bug fixes

* upcoming: [DI-20501] - Add change set

* upcoming: [DI-20501] - Remove non nullish assertion

* upcoming: [DI-20501] - Getting started to Docs

* upcoming: [DI-20501] - changing to themes

* upcoming: [DI-20501] - changing from day to days

* upcoming: [DI-20501] - update changeset

* upcoming: [DI-20501] - timestamp to use REFRESH constant

* upcoming: [DI-20501] - full undefined checks

* upcoming: [DI-20501] - ESlint changes

* upcoming: [DI-20501] - PR comments

* upcoming: [DI-20501] - UT failure fixes

* upcoming: [DI-20501] - Loading icon while jwetoken fetch happening

* upcoming: [DI-20501] - Enable option chain checks

* upcoming: [DI-20501] - ESlint issue fixes

* upcoming: [DI-20501] - is entity for placeholder

* upcoming: [DI-20501] - Enable beta for cloudpulse endpoints

* upcoming: [DI-20501] - Add api-v4 changeset

* upcoming: [DI-20501] - PR comments

* upcoming: [DI-20501] - Code simplification

---------

Co-authored-by: vmangalr <vmangalr@akamai.com>
* update node from `18.14` to `20.17`

* fix typo

* fix area chart unit test

* Added changeset: Update Node.js from `18.14` to `20.17`

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* add apache spark occ

* add apache spark svg files

* add changeset for sept 2024 marketplace

* fix changeset wording
…bled (#10871)

* Allow regions to be searched by ID when Gecko is enabled

* Added changeset: Allow regions to be searched by ID when Gecko is enabled
…ent (#10845)

* upcoming: [DI-20357] - Changes for single reusable component

* upcoming: [DI-20357] - Added a divider after filter

* upcoming: [DI-20357] - Add changeset

* upcoming: [DI-20357] - Code Refactoring

* upcoming: [DI-20357] - Code splitting between utility and component

* upcoming: [DI-20357] - More clean ups

* upcoming: [DI-20357] - Initial PR review comments

* upcoming: [DI-20357] - Moving condition checks

* upcoming: [DI-20357] - Destructure config changes

* upcoming: [DI-20357] - PR comments

* upcoming: [DI-20357] - PR comments

* upcoming: [DI-20357] - Update checks for isFilterBuilderNeeded

* upcoming: [DI-20357] - More test cases

* upcoming: [DI-20357] - Use title

* upcoming: [DI-20357] - Code simplifications and PR comments

* upcoming: [DI-20357] - Code simplifications and PR comments

* upcoming: [DI-20357] - As per develop

* upcoming: [DI-20357] - As per develop

* upcoming: [DI-20357] - Added for undefined case as well

* upcoming: [DI-20357] - Added for resource 0 case as well

* upcoming: [DI-20357] - Server handler fixes

* upcoming: [DI-20357] - Server handler fixes

* upcoming: [DI-20357] - nodeType to role

* upcoming: [DI-20357] - ES lint fix

---------

Co-authored-by: vmangalr <vmangalr@akamai.com>
… original text (#10886)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* Revert "View Code Snippets" button copy to the original text.

* update cypress tests

* Create pr-10886-upcoming-features-1725465397032.md
* Add story for SelectableTableRow component

* Added changeset: SelectableTableRow Story
* feat: [M3-7686] - Restricted access UX for Databases

* Add tests

* Added changeset: Restricted access UX for Databases

* Disabled database resize controls

* Added tests

* Disabled Remove button on access controls

* Removed redundant default value for disabled

* fix
…ptions improvements (#10888)

* Allow Cypress region selection to work with Gecko options improvements

* Add changeset
* feat: [UIE-8054] - DBaaS enhancements 1

* feat: [UIE-8006] - DBaaS create flow enhancements

* fix: [UIE-8084] - DBaaS V2 beta flag

* Review comments: better types.

* changeset

* Review comments: better types and test setup

* fix failing e2e test create-database
#10877)

* Remove flag and undelying logic & update tests

* Added changeset: Delete Placement Groups feature flag conditional rendering

* feedback @mjac0bs @carillo-erik
* Match weblish cols to SSH lish

* Added changeset: Weblish line wrapping
…0890)

* Add unit tests for SelectableTableRow component

* Wrap SelectableTableRow with wrapWithTableBody

* Added changeset: Add unit tests for SelectableTableRow component

* Refactor unit tests to use  for toggling
* Refactor useToastNotification async toasts

* Added changeset: Refactor useToastNotification async toasts

* Clean up and refactor async toasts configuration

* Update e2e test for attach-volume.spec.ts

* Update async toasts e2e tests in clone-linode.spec.ts

* Update async toast e2e tests in linode-storage.spec.ts

* Update async toasts e2e tests in machine-image-upload.spec.ts

* Update e2e tests and disk event messages

* Update other e2e tests

* Refactor asyncToasts and useToastNotifications

* Update types and comments

* Add unit test cases

* Refactor createToast function

* Update createToast to conditionally pass parameters and adjust unit tests

* few fixes on asyncToasts.tsx

* Update event messages for disk

* Clean up: Remove test cases which are already covered
…nces where debouncing is not happening (#10813)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* Apply fix to avoid unintended re-renders  or effect executions

* fix debouncing issue in SelectLinodePanel and LinodeSelectTable

* code cleanup

* Update LongviewClients.tsx

* code cleanup

* Code clean up - remove customValue prop

* PR feedback - @hkhalil-akamai

* Remove onSearch from dependency to avoid unwanted re-triggers

* More code cleanup DebouncedSearchTextField component, removed redundant implementation of clear icon.

* PR feedback - @mjac0bs
* Update security.txt in manager package

* Convert root .txt to .MD file

* Added changeset: Update security policy

* Fix line breaks and linter complaints
@hkhalil-akamai hkhalil-akamai added the Release → Staging Pre-Release: Release → Staging label Sep 13, 2024
@hkhalil-akamai hkhalil-akamai self-assigned this Sep 13, 2024
@hkhalil-akamai hkhalil-akamai requested review from a team as code owners September 13, 2024 15:00
@hkhalil-akamai hkhalil-akamai requested review from jdamore-linode, mjac0bs and jaalah-akamai and removed request for a team September 13, 2024 15:00
packages/manager/cypress/support/ui/autocomplete.ts Dismissed Show dismissed Hide dismissed
packages/manager/cypress/support/ui/autocomplete.ts Dismissed Show dismissed Hide dismissed
packages/manager/cypress/support/ui/autocomplete.ts Dismissed Show dismissed Hide dismissed
packages/manager/cypress/support/ui/autocomplete.ts Dismissed Show resolved Hide resolved
…e A/B Test (#10906)

* unit test coverage for HostNameTableCell

* Revert "unit test coverage for HostNameTableCell"

This reverts commit b274baf.

* Create feature flag for DX tools A/B testing

* Add data attributes for DX tools for tracking

* Update Actions.test.tsx

* Test flag

* Add classname

* Add event emitters to the LD from DX tools

* update with correct keys

* Destructure tabs

* code cleanup

* Add event emitter to Integration and SDK tab resources.

* Add go and python code snippets

* Add Linode CLI Tab Selection

* Remove old ab test code

* Cleanup conditionals

* Add changeset

* Revert "Merge branch 'linode:develop' into develop"

This reverts commit bfed239, reversing
changes made to 342fd96.

* Reapply "Merge branch 'linode:develop' into develop"

This reverts commit 9e54b55.

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
* code cleanup

* fix broken cypress tests for dx tools modal

* wrapping the test in describe block

* Update create-linode-view-code-snippet.spec.ts

* Code cleanup

* Flush ldClient after event fired

* flush after track event is fired

* Update GoSDKResources.tsx
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Release testing
✅ Changelogs with accurate versioning and dates
✅ Version bumps in package.jsons

"vitest": "^1.6.0"
"vitest": "^2.0.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a changelog for search?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to update our changelog scripts to include the search package. @bnussman-akamai is this something we should consider doing?

@hkhalil-akamai hkhalil-akamai merged commit d7a115c into staging Sep 16, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release → Staging Pre-Release: Release → Staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.