Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7971] - Add new tests for for selecting "All" Scopes #10852

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

AzureLatte
Copy link
Contributor

@AzureLatte AzureLatte commented Aug 29, 2024

Description 📝

Ensure that the outgoing API request when creating an API token matches what’s expected for each type of user: regular user, parent user with restricted access, parent user with unrestricted access.

Changes 🔄

  • Add new assertions for regular user in account/personal-access-tokens.spec.ts
  • Add new tests for parent user with restricted access and parent user with unrestricted access in parentChild/token-scopes.spec.ts

How to test 🧪

yarn cy:run -s "cypress/e2e/core/account/personal-access-tokens.spec.ts"
yarn cy:run -s "cypress/e2e/core/parentChild/token-scopes.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte self-assigned this Aug 29, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner August 29, 2024 13:18
@AzureLatte AzureLatte requested review from jdamore-linode and removed request for a team August 29, 2024 13:18
@AzureLatte AzureLatte requested a review from a team as a code owner August 29, 2024 13:19
@AzureLatte AzureLatte requested review from hana-akamai and harsh-akamai and removed request for a team August 29, 2024 13:19
Copy link

github-actions bot commented Aug 29, 2024

Coverage Report:
Base Coverage: 82.74%
Current Coverage: 82.74%

@AzureLatte AzureLatte changed the title Add new tests for for selecting "All" Scopes test: [M3-7971] - Add new tests for for selecting "All" Scopes Aug 29, 2024
@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Sep 5, 2024
@AzureLatte AzureLatte merged commit 079a200 into linode:develop Sep 10, 2024
19 checks passed
@AzureLatte AzureLatte deleted the M3-7971 branch September 10, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants