Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7142] - Update helper text copy in NodeBalancer Create form 'Algorithm' field #10855

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Aug 29, 2024

Description 📝

  • Updates helper text for Round Robin algorithm and only shows helper text relevant to the selected algorithm

Changes

  • Updated helper text copy for the 'algorithm' field + updated additional helper text copies as specified
  • Added unit tests for config panel
  • some eslint fixes whenever I landed on a file that had them

Target release date 🗓️

n/a

Preview 📷

Before After
image image imageimage

How to test 🧪

Reproduction steps

  • Navigate to NodeBalancer create form, note the helper text underneath the 'Algorithm' field

Verification steps

  • Confirm copies for each algorithm field as specified by ticket
  • confirm create flow still works as expected
  • yarn test NodeBalancerConfigPanel.test.tsx

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai added the Bug Fixes for regressions or bugs label Aug 29, 2024
@coliu-akamai coliu-akamai self-assigned this Aug 29, 2024
@coliu-akamai coliu-akamai marked this pull request as ready for review August 29, 2024 15:14
@coliu-akamai coliu-akamai requested a review from a team as a code owner August 29, 2024 15:14
@coliu-akamai coliu-akamai requested review from dwiley-akamai, hkhalil-akamai and mjac0bs and removed request for a team August 29, 2024 15:14
Copy link

github-actions bot commented Aug 29, 2024

Coverage Report:
Base Coverage: 86.04%
Current Coverage: 86.05%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our test coverage of NodeBalancers has been lacking for a long time and your additional coverage here is awesome to have!

Confirmed the config panel Algorithm field looks good now and helper text across the form is consistent. Thanks for tackling this one. The original typo had been around for 5+ years - I remember checking when I made the ticket.

weight: 100,
};

const props: NodeBalancerConfigPanelProps = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. 😅

…Panel.test.tsx

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Aug 30, 2024
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NodeBalancerConfigPanel.test.tsx passes locally and in CI ✅
Confirmed copy updates when a different Algorithm is selected ✅
No regressions observed when creating a NodeBalancer ✅
Code review ✅

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 30, 2024
@coliu-akamai coliu-akamai merged commit 59a4e9f into linode:develop Aug 30, 2024
18 of 19 checks passed
@coliu-akamai coliu-akamai deleted the m3-7142 branch September 6, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants