-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-7142] - Update helper text copy in NodeBalancer Create form 'Algorithm' field #10855
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our test coverage of NodeBalancers has been lacking for a long time and your additional coverage here is awesome to have!
Confirmed the config panel Algorithm field looks good now and helper text across the form is consistent. Thanks for tackling this one. The original typo had been around for 5+ years - I remember checking when I made the ticket.
weight: 100, | ||
}; | ||
|
||
const props: NodeBalancerConfigPanelProps = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. 😅
packages/manager/src/features/NodeBalancers/NodeBalancerConfigPanel.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/NodeBalancers/NodeBalancerConfigPanel.test.tsx
Show resolved
Hide resolved
…Panel.test.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NodeBalancerConfigPanel.test.tsx
passes locally and in CI ✅
Confirmed copy updates when a different Algorithm is selected ✅
No regressions observed when creating a NodeBalancer ✅
Code review ✅
Description 📝
Changes
Target release date 🗓️
n/a
Preview 📷
How to test 🧪
Reproduction steps
Verification steps
yarn test NodeBalancerConfigPanel.test.tsx
As an Author I have considered 🤔
Check all that apply