Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8511] - Refactor and Improve the User Details Page #10861

Conversation

bnussman-akamai
Copy link
Contributor

@bnussman-akamai bnussman-akamai commented Aug 30, 2024

Description 📝

  • Improves the UI and UX of the user details page (only the profile tab) 👤
  • Refactors user details page to use our latest patterns so that it will be easy to understand and maintain 🧹

Preview 📷

Before After
Screenshot 2024-08-29 at 10 00 54 PM Screenshot 2024-08-29 at 10 01 08 PM
Broken UI and very little information 😞 Better looking UI and more information shown for transparency ✨

How to test 🧪

  • Test the user details page (the profile tab) in depth 🔍
  • Test on parent child accounts (parent, proxy, etc...) 👥
  • Test updating email on the user details page ✏️
  • Test updating username on the user details page ✏️

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this Aug 30, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review August 30, 2024 02:11
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner August 30, 2024 02:11
@bnussman-akamai bnussman-akamai requested review from dwiley-akamai and carrillo-erik and removed request for a team August 30, 2024 02:11
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner August 30, 2024 02:11
@bnussman-akamai bnussman-akamai requested review from cliu-akamai and removed request for a team August 30, 2024 02:11
Copy link

github-actions bot commented Aug 30, 2024

Coverage Report:
Base Coverage: 86.13%
Current Coverage: 86.13%

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🧹
Parent/Child looks good still from all three views (Parent, Proxy, Child)
Screenshot 2024-08-30 at 10 34 11 AM
Screenshot 2024-08-30 at 10 49 10 AM

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 30, 2024
Copy link
Contributor

@carrillo-erik carrillo-erik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work, I really like the UI improvements as it makes the information easier to consume. Also, I appreciate the breakdown of the UserProfile component into separate Panels. Finally, thank you for improving both the unit and e2e tests.

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 30, 2024
@bnussman-akamai bnussman-akamai merged commit 990fa49 into linode:develop Sep 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Clean Up Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants