test: [M3-8485] - Unit Tests for Object Storage Gen2 feature #10862

harsh-akamai · 2024-08-30T06:18:00Z

Description 📝

Unit tests for Bucket Landing page, Bucket Detail Drawer and Object Detail Drawers.

Changes 🔄

Added test to check if "Endpoint Type" column is displayed
Added test to check if the CORS switch is disabled for E2 and E3 buckets in the Bucket Details Drawer
Added test to check if the Bucket Rate Limit table is rendered for E2 and E3 buckets in the Bucket Detail Drawer
Added test to check if the ACL switch is disabled for E2 and E3 buckets in the Object Details Drawer

Target release date 🗓️

N/A

How to test 🧪

Verification steps

Run the unit tests for Object Storage feature and check if all tests pass.

As an Author I have considered 🤔

Check all that apply

github-actions · 2024-08-30T06:43:21Z

Coverage Report: ✅
Base Coverage: 86.41%
Current Coverage: 86.41%

coliu-akamai

✅ confirmed tests pass - thanks for adding test coverage!

Some v small comments + one question below

packages/manager/src/features/ObjectStorage/BucketLanding/BucketDetailsDrawer.test.tsx

packages/manager/src/features/ObjectStorage/BucketLanding/BucketTable.test.tsx

coliu-akamai · 2024-08-30T16:53:03Z

packages/manager/src/features/ObjectStorage/BucketLanding/BucketDetailsDrawer.tsx

@@ -141,7 +141,7 @@ export const BucketDetailsDrawer = React.memo(
        )}
        {/* @TODO OBJ Multicluster: use region instead of cluster if isObjMultiClusterEnabled
         to getBucketAccess and updateBucketAccess.  */}
-        {
+        {Boolean(endpoint_type) && (


are the changes in this file just for stuff that was missed earlier? I don't see anything mentioned in the AC or ticket description about them

Yes, these changes are stuff that was missed earlier.

…cts-unit-and-itegration-tests

cpathipa

All tests passed! thank you adding unit test coverage.

hkhalil-akamai · 2024-09-03T19:29:19Z

The ticket mentions updating integration tests to reflect the new changes. Is this still required (perhaps updating bucket-create-gen2.spec.ts)?

harsh-akamai · 2024-09-04T06:22:05Z

The ticket mentions updating integration tests to reflect the new changes. Is this still required (perhaps updating bucket-create-gen2.spec.ts)?

@hkhalil-akamai the ticket asked to perform integration tests to ensure the UI changes function as expected without affecting other feature. If we need to update the integration tests I guess handling that in a different ticket/PR would be better

…cts-unit-and-itegration-tests

hkhalil-akamai · 2024-09-10T21:32:57Z

packages/manager/src/features/ObjectStorage/BucketLanding/BucketDetailsDrawer.test.tsx

Using renderWithThemeAndHookFormContext is unnecessary since the component doesn't need a Hook Form Context. Use renderWithTheme instead.

Currently the component doesn't need a Hook Form, but M3-8501(optimzing AccessSelect.tsx using Hook Form) is in progress. Hence, I decided to go with renderWithThemeAndHookFormContext

Ohhh understood. Sounds good!

For future reference, each PR should be self-contained and generally should not include changes for another ticket. This prevents issues when, for example, the other ticket is closed or modified.

Noted 🗒️

hkhalil-akamai · 2024-09-10T21:33:07Z

packages/manager/src/features/ObjectStorage/BucketLanding/BucketDetailsDrawer.test.tsx

+    const { getByTestId } = renderWithThemeAndHookFormContext({
+      component: (
+        <BucketDetailsDrawer
+          onClose={mockOnClose}
+          open={true}
+          selectedBucket={e3Bucket}
+        />
+      ),
+      options: {
+        flags: { objMultiCluster: false, objectStorageGen2: { enabled: true } },
+      },
+    });
+
+    const rateLimitTable = getByTestId('bucket-rate-limit-table');


This test is failing since isObjectStorageGen2Enabled is derived from an RQ hook and is initially undefined. Awaiting via await findByTestId will wait for the query to resolve.

Suggested change

const { getByTestId } = renderWithThemeAndHookFormContext({

component: (

<BucketDetailsDrawer

onClose={mockOnClose}

open={true}

selectedBucket={e3Bucket}

/>

),

options: {

flags: { objMultiCluster: false, objectStorageGen2: { enabled: true } },

},

});

const rateLimitTable = getByTestId('bucket-rate-limit-table');

const { findByTestId } = renderWithTheme(

<BucketDetailsDrawer

onClose={mockOnClose}

open={true}

selectedBucket={e3Bucket}

/>,

{

flags: { objMultiCluster: false, objectStorageGen2: { enabled: true } },

}

);

const rateLimitTable = await findByTestId('bucket-rate-limit-table');

Thank you so much for pointing this out! I've made the changes in 8974ea4

hkhalil-akamai · 2024-09-10T21:33:47Z

packages/manager/src/features/ObjectStorage/BucketLanding/BucketDetailsDrawer.test.tsx

+    const { getByText } = renderWithThemeAndHookFormContext({
+      component: (
+        <BucketDetailsDrawer
+          onClose={mockOnClose}
+          open={true}
+          selectedBucket={e1Bucket}
+        />
+      ),
+      options: {
+        flags: { objMultiCluster: false, objectStorageGen2: { enabled: true } },
+      },
+    });
+    expect(
+      getByText(
+        /This endpoint type supports up to 750 Requests Per Second \(RPS\)./
+      )
+    ).toBeInTheDocument();


Suggested change

const { getByText } = renderWithThemeAndHookFormContext({

component: (

<BucketDetailsDrawer

onClose={mockOnClose}

open={true}

selectedBucket={e1Bucket}

/>

),

options: {

flags: { objMultiCluster: false, objectStorageGen2: { enabled: true } },

},

});

expect(

getByText(

/This endpoint type supports up to 750 Requests Per Second \(RPS\)./

)

).toBeInTheDocument();

const { findByText } = renderWithTheme(

<BucketDetailsDrawer

onClose={mockOnClose}

open={true}

selectedBucket={e1Bucket}

/>,

{

flags: { objMultiCluster: false, objectStorageGen2: { enabled: true } },

}

);

expect(

await findByText(

/This endpoint type supports up to 750 Requests Per Second \(RPS\)./

)

).toBeInTheDocument();

hkhalil-akamai

Thanks for making requested changes! Approved pending CI passes!

hkhalil-akamai · 2024-09-11T15:53:35Z

packages/manager/src/features/ObjectStorage/BucketLanding/BucketDetailsDrawer.test.tsx

Ohhh understood. Sounds good!

…10862) * upcoming:[M3-8485] - Browsing Buckets & Objects - Unit Tests * test: Unit test for 'Endpoint Type' column in the Bucket Landing Table * test: [M3-8485] - updated tests for object storage bucket feature * test: [M3-8485] fixed failing unit test * test: [M3-8485] - udpated tests that need to wait for OBJGen2 flag

upcoming:[M3-8485] - Browsing Buckets & Objects - Unit Tests

35c2bab

harsh-akamai added the Object Storage Gen2 label Aug 30, 2024

harsh-akamai requested a review from jaalah-akamai August 30, 2024 06:18

harsh-akamai self-assigned this Aug 30, 2024

harsh-akamai requested a review from a team as a code owner August 30, 2024 06:18

harsh-akamai requested review from cpathipa, hkhalil-akamai and coliu-akamai and removed request for a team August 30, 2024 06:18

harsh-akamai force-pushed the feature/M3-8485-browsing-buckets-and-objects-unit-and-itegration-tests branch from 475d702 to 35c2bab Compare August 30, 2024 06:37

test: Unit test for 'Endpoint Type' column in the Bucket Landing Table

57411a5

bnussman-akamai changed the title ~~test: [M3-8485] -Unit Tests for Object Storage Gen2 feature~~ test: [M3-8485] - Unit Tests for Object Storage Gen2 feature Aug 30, 2024

coliu-akamai reviewed Aug 30, 2024

View reviewed changes

harsh-akamai added 2 commits September 2, 2024 10:17

Merge branch 'develop' into feature/M3-8485-browsing-buckets-and-obje…

f604929

…cts-unit-and-itegration-tests

test: [M3-8485] - updated tests for object storage bucket feature

25d4b26

coliu-akamai approved these changes Sep 3, 2024

View reviewed changes

cpathipa approved these changes Sep 3, 2024

View reviewed changes

mjac0bs added the Approved Multiple approvals and ready to merge! label Sep 3, 2024

hkhalil-akamai approved these changes Sep 4, 2024

View reviewed changes

harsh-akamai added 3 commits September 5, 2024 16:12

Merge branch 'develop' into feature/M3-8485-browsing-buckets-and-obje…

eef2af5

…cts-unit-and-itegration-tests

Merge branch 'develop' into feature/M3-8485-browsing-buckets-and-obje…

9c1d0e8

…cts-unit-and-itegration-tests

test: [M3-8485] fixed failing unit test

da4b474

hkhalil-akamai requested changes Sep 10, 2024

View reviewed changes

test: [M3-8485] - udpated tests that need to wait for OBJGen2 flag

8974ea4

harsh-akamai removed the Approved Multiple approvals and ready to merge! label Sep 11, 2024

hkhalil-akamai approved these changes Sep 11, 2024

View reviewed changes

packages/manager/src/features/ObjectStorage/BucketLanding/BucketDetailsDrawer.test.tsx

Copy link

Contributor

hkhalil-akamai Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh understood. Sounds good!

mjac0bs added the Approved Multiple approvals and ready to merge! label Sep 11, 2024

harsh-akamai merged commit 6581070 into linode:develop Sep 12, 2024
19 checks passed

harsh-akamai deleted the feature/M3-8485-browsing-buckets-and-objects-unit-and-itegration-tests branch September 12, 2024 06:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: [M3-8485] - Unit Tests for Object Storage Gen2 feature #10862

test: [M3-8485] - Unit Tests for Object Storage Gen2 feature #10862

harsh-akamai commented Aug 30, 2024 •

edited

Loading

github-actions bot commented Aug 30, 2024 •

edited

Loading

coliu-akamai left a comment

coliu-akamai Aug 30, 2024

harsh-akamai Sep 2, 2024

cpathipa left a comment

hkhalil-akamai commented Sep 3, 2024

harsh-akamai commented Sep 4, 2024

hkhalil-akamai Sep 10, 2024

harsh-akamai Sep 11, 2024

hkhalil-akamai Sep 11, 2024

hkhalil-akamai Sep 11, 2024 •

edited

Loading

harsh-akamai Sep 11, 2024

hkhalil-akamai Sep 10, 2024

harsh-akamai Sep 11, 2024

hkhalil-akamai Sep 10, 2024

hkhalil-akamai left a comment

hkhalil-akamai Sep 11, 2024

test: [M3-8485] - Unit Tests for Object Storage Gen2 feature #10862

test: [M3-8485] - Unit Tests for Object Storage Gen2 feature #10862

Conversation

harsh-akamai commented Aug 30, 2024 • edited Loading

Description 📝

Changes 🔄

Target release date 🗓️

How to test 🧪

Verification steps

As an Author I have considered 🤔

github-actions bot commented Aug 30, 2024 • edited Loading

coliu-akamai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpathipa left a comment

Choose a reason for hiding this comment

hkhalil-akamai commented Sep 3, 2024

harsh-akamai commented Sep 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hkhalil-akamai Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hkhalil-akamai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harsh-akamai commented Aug 30, 2024 •

edited

Loading

github-actions bot commented Aug 30, 2024 •

edited

Loading

hkhalil-akamai Sep 11, 2024 •

edited

Loading